Move from unload to pagehide to avoid using deprecated API

logux · Apr 2, 2024 · fba42bc · fba42bc
1 parent a82db02
commit fba42bc
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 4 deletions.
diff --git a/client/index.js b/client/index.js
@@ -291,7 +291,7 @@ export class Client {
 
     this.onUnload = this.onUnload.bind(this)
     if (typeof window !== 'undefined' && window.addEventListener) {
-      window.addEventListener('unload', this.onUnload)
+      window.addEventListener('pagehide', this.onUnload)
     }
 
     this.processing = {}
@@ -347,7 +347,7 @@ export class Client {
     this.node.destroy()
     clearInterval(this.pinging)
     if (typeof window !== 'undefined' && window.removeEventListener) {
-      window.removeEventListener('unload', this.onUnload)
+      window.removeEventListener('pagehide', this.onUnload)
     }
   }
 

diff --git a/client/index.test.ts b/client/index.test.ts
@@ -383,7 +383,7 @@ it('cleans own actions on unload', async () => {
     { type: 'A' },
     { reasons: ['tab' + client.tabId], tab: client.tabId }
   )
-  window.dispatchEvent(new Event('unload'))
+  window.dispatchEvent(new Event('pagehide'))
   await delay(10)
   expect(client.log.actions()).toHaveLength(0)
   expect(localStorage.getItem('test:tab:' + client.tabId)).toBeNull()

diff --git a/cross-tab-client/index.js b/cross-tab-client/index.js
@@ -70,7 +70,7 @@ export class CrossTabClient extends Client {
 
     if (typeof window !== 'undefined' && window.addEventListener) {
       window.addEventListener('storage', e => this.onStorage(e))
-      window.addEventListener('unload', e => this.onUnload(e))
+      window.addEventListener('pagehide', e => this.onUnload(e))
     }
 
     if (this.isLocalStorage) {