Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use async/await #55

Open
ai opened this Issue Apr 9, 2019 · 4 comments

Comments

Projects
None yet
2 participants
@ai
Copy link
Member

commented Apr 9, 2019

Logux Server 0.3 requires Node.js >= 10, so we are safe to use async/await instead of Promise

@ai

This comment has been minimized.

Copy link
Member Author

commented Apr 24, 2019

Part of the works was done in #58

@chafilin can you show me links to the code, where you have problems in replacing Promise?

@ai

This comment has been minimized.

Copy link
Member Author

commented Apr 24, 2019

@chafilin don’t forget about tests. They are the main users of .then.

@chafilin

This comment has been minimized.

Copy link
Contributor

commented Apr 25, 2019

Part of the works was done in #58

@chafilin can you show me links to the code, where you have problems in replacing Promise?

This kind of Promises:

processing[meta.id] = new Promise((resolve, reject) => {

return new Promise((resolve, reject) => {

@ai

This comment has been minimized.

Copy link
Member Author

commented Apr 25, 2019

Yeap. Let’s keep Promise in those 2 examples.

I am waiting for PR to replace then in tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.