Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor to async/await #58

Merged
merged 14 commits into from
Apr 24, 2019
Merged

Refactor to async/await #58

merged 14 commits into from
Apr 24, 2019

Conversation

chafilin
Copy link
Contributor

@chafilin chafilin commented Apr 24, 2019 •
edited
Loading

Issue #55

  1. Changed all .then constuctions to async/await. Except base-server.js and filter method in server-client.js
  2. Did't touch force-promise, because after refactoring whole code it will be useless
  3. Don't know how to refactor promisify and retrurn new Promise with wrapping callback

ai
ai reviewed Apr 24, 2019
View reviewed changes
server.js Outdated Show resolved Hide resolved
@ai
Copy link
Member

ai commented Apr 24, 2019

We can do it separated PR. Let’s merge this PR if it passes tests. And then we will continue discussing other Promise parts in #55.

@ai ai marked this pull request as ready for review April 24, 2019 16:29
@chafilin
Copy link
Contributor Author

@ai Can you help, please? It fails on jsdoc step

@ai
Copy link
Member

ai commented Apr 24, 2019

It is recent JSDoc + Node.js 12 compatibility problem. I created the issue. Replace node to "11" in .travis.yml.

@ai ai merged commit b47dccd into logux:master Apr 24, 2019
@ai ai mentioned this pull request Apr 24, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ai ai ai left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@chafilin @ai