Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP first working netcoreapp3.1 migration #443

Closed
wants to merge 6 commits into from
Closed

WIP first working netcoreapp3.1 migration #443

wants to merge 6 commits into from

Conversation

MarkZither
Copy link
Contributor

WIP migration to .netcoreapp3.1, so bits to finish around the routing and some bits to revert.

  • Update the project file and remove/add relevant package references
  • Change BaGet.Core.Server to use Microsoft.NET.Sdk.Web and target netcoreapp3.1 for MVC references
  • Change from IHostingEnvironment to IWebHostEnvironment
    Fix a duplicate route that is throwing and exception for SymbolDownloadRouteName as also done in wagnerhsu's fork
  • Add .AddNewtonsoftJson(options => { options.SerializerSettings.DateTimeZoneHandling = DateTimeZoneHandling.Utc; });
  • Migrate from deprecated UseMvc to UseRouting and UseEndpoints (having issues finding the controllers in BaGet.Core.Server. Checking Share controllers, views, Razor Pages and more with Application Parts and .NET core 3 route failure with separate projects

Addresses #439

@loic-sharma
Copy link
Owner

having issues finding the controllers in BaGet.Core.Server. Checking Share controllers, views, Razor Pages and more with Application Parts and .NET core 3 route failure with separate projects

I was able to get routing to work by removing Async suffixes from the action names in my routes. See this comment: #439 (comment). My link generation is still broken though, I'm still investigating that

@MarkZither MarkZither changed the base branch from master to update-aspnet3 January 19, 2020 21:03
@loic-sharma loic-sharma mentioned this pull request Jan 20, 2020
Merged
16 tasks
loic-sharma added a commit that referenced this pull request Jan 21, 2020
@loic-sharma
Update to ASP.NET Core 3.0 (#444)
05bfc61 
Updates BaGet to ASP.NET Core 3.0. This is based off @MarkZither's work (see #443). Thank you for all the help @MarkZither!

⚠️ Many of BaGet's projects will **temporarily** require .NET Core 3 because EF Core 3.0 requires .NET Standard 2.1. EF Core 3.1 reintroduced .NET Standard 2.0 support. I will re-add .NET Framework and .NET Standard 2.0 support once I've migrated BaGet to ASP.NET Core 3.1.

Part of #439
@loic-sharma loic-sharma mentioned this pull request Jan 21, 2020
Merged
18 tasks
@loic-sharma
Copy link
Owner

Hi @MarkZither, I merged the update to ASP.NET Core 3.0 (#444) and opened a new pull request for ASP.NET Core 3.1 (#446). I fixed the EF Core 3.1 warnings like no value comparer.

I'm currently investigating exceptions thrown by the ASP.NET Core 3.1 SPA services... It seems proxying is a little flaky, but I'm not sure why.

loic-sharma added a commit that referenced this pull request Jan 22, 2020
@loic-sharma
Update to ASP.NET Core 3.1 (#446)
df8a805 
Updates BaGet to ASP.NET Core 3.1. This is based off @MarkZither's work (see #443). Thank you for all the help @MarkZither!

Part of #439
@loic-sharma
Copy link
Owner

Hey @MarkZither, I merged your changes as part of #446. Thank you for starting this project!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@loic-sharma loic-sharma loic-sharma left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@MarkZither @loic-sharma