Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to ASP.NET Core 3.0 #444

Merged
merged 19 commits into from
Jan 21, 2020
Merged

Update to ASP.NET Core 3.0 #444

merged 19 commits into from
Jan 21, 2020

Conversation

loic-sharma
Copy link
Owner

@loic-sharma loic-sharma commented Jan 20, 2020 •
edited
Loading

Updates BaGet to ASP.NET Core 3.0. This is based off @MarkZither's work (see #443). Thank you for all the help @MarkZither!

⚠️ Many of BaGet's projects will temporarily require .NET Core 3 because EF Core 3.0 requires .NET Standard 2.1. EF Core 3.1 reintroduced .NET Standard 2.0 support. I will re-add .NET Framework and .NET Standard 2.0 support once I've migrated BaGet to ASP.NET Core 3.1.

Test plan

Build: https://dev.azure.com/sharml/BaGet/_build/results?buildId=1119

  • Databases
    • SQLite
    • MySQL
    • PostgreSQL
    • SQL Server
  • Storage
    • Azure
    • Filesystem
    • GCP
    • AWS
  • Docker
  • GitHub release
  • Clients
    • nuget.exe
    • dotnet CLI
    • Visual Studio

Part of #439

loic-sharma
loic-sharma commented Jan 21, 2020
View reviewed changes
src/BaGet.Core/Search/DatabaseSearchService.cs
.Distinct()
.OrderBy(id => id)
Copy link
Owner Author

@loic-sharma loic-sharma Jan 21, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a works around an EF Core 3 bug. See npgsql/efcore.pg#1195 (comment)

@loic-sharma
Copy link
Owner Author

This change introduces the log The property ... was created in shadow state because... at startup. I'll fix this later. See: #445

loic-sharma
loic-sharma commented Jan 21, 2020
View reviewed changes
src/BaGet.Aws/BaGet.Aws.csproj
@@ -1,7 +1,7 @@
<Project Sdk="Microsoft.NET.Sdk">

<PropertyGroup>
<TargetFrameworks>netstandard2.0;net461</TargetFrameworks>
<TargetFrameworks>netcoreapp3.0</TargetFrameworks>
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ This project will temporarily require .NET Core 3 as EF Core 3.0 requires .NET Standard 2.1. EF Core 3.1 reintroduced .NET Standard 2.0 support. I will re-add .NET Framework and .NET Standard 2.0 support once I've migrated BaGet to ASP.NET Core 3.1.

loic-sharma
loic-sharma commented Jan 21, 2020
View reviewed changes
src/BaGet.Azure/BaGet.Azure.csproj
@@ -1,7 +1,7 @@
<Project Sdk="Microsoft.NET.Sdk">

<PropertyGroup>
<TargetFrameworks>netstandard2.0;net461</TargetFrameworks>
<TargetFrameworks>netcoreapp3.0</TargetFrameworks>
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ This project will temporarily require .NET Core 3 as EF Core 3.0 requires .NET Standard 2.1. EF Core 3.1 reintroduced .NET Standard 2.0 support. I will re-add .NET Framework and .NET Standard 2.0 support once I've migrated BaGet to ASP.NET Core 3.1.

loic-sharma
loic-sharma commented Jan 21, 2020
View reviewed changes
src/BaGet.Core/BaGet.Core.csproj
@@ -1,7 +1,7 @@
<Project Sdk="Microsoft.NET.Sdk">

<PropertyGroup>
<TargetFrameworks>netstandard2.0;net461</TargetFrameworks>
<TargetFrameworks>netcoreapp3.0</TargetFrameworks>
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ This project will temporarily require .NET Core 3 as EF Core 3.0 requires .NET Standard 2.1. EF Core 3.1 reintroduced .NET Standard 2.0 support. I will re-add .NET Framework and .NET Standard 2.0 support once I've migrated BaGet to ASP.NET Core 3.1.

loic-sharma
loic-sharma commented Jan 21, 2020
View reviewed changes
src/BaGet.Database.PostgreSql/BaGet.Database.PostgreSql.csproj
@@ -1,11 +1,11 @@
<Project Sdk="Microsoft.NET.Sdk">

<PropertyGroup>
<TargetFrameworks>netstandard2.0;net461</TargetFrameworks>
<TargetFrameworks>netcoreapp3.0</TargetFrameworks>
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ This project will temporarily require .NET Core 3 as EF Core 3.0 requires .NET Standard 2.1. EF Core 3.1 reintroduced .NET Standard 2.0 support. I will re-add .NET Framework and .NET Standard 2.0 support once I've migrated BaGet to ASP.NET Core 3.1.

loic-sharma
loic-sharma commented Jan 21, 2020
View reviewed changes
src/BaGet.Database.SqlServer/BaGet.Database.SqlServer.csproj
@@ -1,7 +1,7 @@
<Project Sdk="Microsoft.NET.Sdk">

<PropertyGroup>
<TargetFrameworks>netstandard2.0;net461</TargetFrameworks>
<TargetFrameworks>netcoreapp3.0</TargetFrameworks>
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ This project will temporarily require .NET Core 3 as EF Core 3.0 requires .NET Standard 2.1. EF Core 3.1 reintroduced .NET Standard 2.0 support. I will re-add .NET Framework and .NET Standard 2.0 support once I've migrated BaGet to ASP.NET Core 3.1.

loic-sharma
loic-sharma commented Jan 21, 2020
View reviewed changes
src/BaGet.Database.Sqlite/BaGet.Database.Sqlite.csproj
@@ -1,7 +1,7 @@
<Project Sdk="Microsoft.NET.Sdk">

<PropertyGroup>
<TargetFrameworks>netstandard2.0;net461</TargetFrameworks>
<TargetFrameworks>netcoreapp3.0</TargetFrameworks>
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ This project will temporarily require .NET Core 3 as EF Core 3.0 requires .NET Standard 2.1. EF Core 3.1 reintroduced .NET Standard 2.0 support. I will re-add .NET Framework and .NET Standard 2.0 support once I've migrated BaGet to ASP.NET Core 3.1.

loic-sharma
loic-sharma commented Jan 21, 2020
View reviewed changes
src/BaGet.Gcp/BaGet.Gcp.csproj
@@ -1,7 +1,7 @@
<Project Sdk="Microsoft.NET.Sdk">

<PropertyGroup>
<TargetFrameworks>netstandard2.0;net461</TargetFrameworks>
<TargetFrameworks>netcoreapp3.0</TargetFrameworks>
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ This project will temporarily require .NET Core 3 as EF Core 3.0 requires .NET Standard 2.1. EF Core 3.1 reintroduced .NET Standard 2.0 support. I will re-add .NET Framework and .NET Standard 2.0 support once I've migrated BaGet to ASP.NET Core 3.1.

@loic-sharma loic-sharma merged commit 05bfc61 into master Jan 21, 2020
@loic-sharma loic-sharma mentioned this pull request Jan 21, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@loic-sharma