Allow multiple primary tags #25
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Multiple primary tags proved to not be unusual since two separate class trees were often used. Allow for this but require them all to be mapped in order to skip the others. Also: * Removed one inappropriate primary_tag which is always unmapped.
lokal-profil
commented
Jun 7, 2017
| for tag in self.item_classes: | ||
| if tag != primary_tag: |
There was a problem hiding this comment.
Dropped this since all() terminates at the first failure hence later primary tags should be added.
Vesihiisi
reviewed
Jun 8, 2017
KMB/make_KMB_info.py
Outdated
| * item_classes: (human construct, building, castle) returns [castle] | ||
| * item_classes: (human construct, building, church) returns [] | ||
| * item_classes: (building, castle, animal, chicken) returns | ||
| [runestone, chicken] |
There was a problem hiding this comment.
Why does it return runestone instead of castle?
There was a problem hiding this comment.
Because I am sloppy =)
Fixed.
Vesihiisi
approved these changes
Jun 8, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Multiple primary tags proved to not be unusual since two separate
class trees were often used. Allow for this but require them all to
be mapped in order to skip the others.
Also:
Task: T167352