Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate searches to use client side collection #1

Closed
lokenx opened this issue Mar 16, 2015 · 1 comment
Closed

Migrate searches to use client side collection #1

lokenx opened this issue Mar 16, 2015 · 1 comment
Assignees

Comments

@lokenx
Copy link
Owner

lokenx commented Mar 16, 2015

This seems like the appropriate way to do the API search. The search results don't need to ever hit the server as they're only temporary, the movie they choose is only one that needs to be written to server.

Also, because this is being put into a collection I should be able to display a simple search or loading animation/text while search is happening. OMDB searches are typically fast, but on occasion they aren't instantaneous and the user has no way of knowing if their search went through or not.

@lokenx lokenx self-assigned this Mar 16, 2015
@lokenx
Copy link
Owner Author

lokenx commented Mar 17, 2015

Completed as of last commit (c839e69). I did a whole bunch out of order because I just coded not thinking to commit so it's super unsafe to revert to any of those commits done at same time, the only one I'd trust is the last one linked above (even though it has nothing to do with this issue).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant