Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.lb-dataContainer fade in bug #116

Closed
TaleTN opened this issue Oct 20, 2013 · 1 comment
Closed

.lb-dataContainer fade in bug #116

TaleTN opened this issue Oct 20, 2013 · 1 comment
Milestone

Comments

@TaleTN
Copy link

TaleTN commented Oct 20, 2013

.lb-dataContainer doesn't fade in at the right speed, because it uses the undefined resizeDuration instead of options.resizeDuration.

Patch:

diff --git a/js/lightbox.js b/js/lightbox.js
index 4d00c54..9fa06d2 100644
--- a/js/lightbox.js
+++ b/js/lightbox.js
@@ -264,7 +264,7 @@ Licensed under the Creative Commons Attribution 2.5 License - http://creativecom
         this.$lightbox.find('.lb-number').hide();
       }
       this.$outerContainer.removeClass('animating');
-      this.$lightbox.find('.lb-dataContainer').fadeIn(this.resizeDuration, function() {
+      this.$lightbox.find('.lb-dataContainer').fadeIn(this.options.resizeDuration, function() {
         return _this.sizeOverlay();
       });
     };
@lokesh lokesh added this to the 2.7.0 milestone Mar 25, 2014
@lokesh
Copy link
Owner

lokesh commented Mar 25, 2014

I was slow to get to this, but this fix is going out with the next release. l'll give you credit. Thanks.

@lokesh lokesh closed this as completed Mar 25, 2014
lokesh added a commit that referenced this issue Mar 25, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants