-
Notifications
You must be signed in to change notification settings - Fork 168
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Custom Public Chats #35
Conversation
Replace hard coded public chat server with dynamic one.
# Conflicts: # src/org/thoughtcrime/securesms/loki/DisplayNameActivity.kt
…into custom-server
Migration failed for me |
And on clean install the app crashed when I hit the home screen |
AndroidManifest.xml
Outdated
@@ -477,8 +477,12 @@ | |||
android:configChanges="touchscreen|keyboard|keyboardHidden|orientation|screenLayout|screenSize" /> | |||
|
|||
<activity android:name="org.thoughtcrime.securesms.loki.NewConversationActivity" | |||
android:windowSoftInputMode="stateAlwaysVisible" | |||
android:configChanges="touchscreen|keyboard|keyboardHidden|orientation|screenLayout|screenSize" /> | |||
android:windowSoftInputMode="stateAlwaysVisible" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Different indentation for each entry?
res/xml/preferences.xml
Outdated
@@ -41,6 +41,10 @@ | |||
android:title="@string/activity_settings_show_qr_code_button_title" | |||
android:icon="@drawable/icon_qr_code"/> | |||
|
|||
<Preference android:key="preference_category_public_chat" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Putting this in the settings menu is bad UX
@@ -71,7 +71,7 @@ | |||
private static final int lokiV2 = 23; | |||
private static final int lokiV3 = 24; | |||
|
|||
private static final int DATABASE_VERSION = lokiV2; // Loki - onUpgrade(...) must be updated to use Loki version numbers if Signal makes any database changes | |||
private static final int DATABASE_VERSION = lokiV3; // Loki - onUpgrade(...) must be updated to use Loki version numbers if Signal makes any database changes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Like I mentioned, migration didn't work for me
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should work for others since we haven't released the beta on lokiV3
, only us devs would have to reinstall an app from scratch
override fun onCreate(bundle: Bundle?, isReady: Boolean) { | ||
supportActionBar!!.setTitle(R.string.fragment_add_public_chat_title) | ||
supportActionBar!!.setDisplayHomeAsUpEnabled(true) | ||
setContentView(R.layout.fragment_add_public_chat) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be activity_add_public_chat
as you're not using a fragment
I fixed the crash and refactored the other stuff I commented on, but still to do is: • Migration |
I'm merging this. We can fix the deleting and re-adding bug on |
No description provided.