-
Notifications
You must be signed in to change notification settings - Fork 222
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Persistent JSON storage #373
Comments
@shivenmian please join in |
Okay so @Orbiter, for storage per se, this does look like a nice idea which can be implemented, but I want to ask: we're gonna use this for storing the public / private keys right? And they will be used to encrypt the passwords the user fill when they fill the sign-up form? Just to be clear. |
If I get this right, the overall direction is what's discussed in #353 (see also #375) But maybe we should think this together with the login mechanism, as we could grant known loklak peers special previleges on certain apis (allowing login either by username/password or a challange as described by #377 ) @Orbiter is ok if we start with the login mechanism #363 to have that finished up and then come back on this whole batch of issues? |
@shivenmian #373 (comment) no |
@shivenmian I created a class for this, could you have a look and help me testing if you have time? |
Sure. Link? |
Ah right, here |
@treba123 I haven't pulled your code because I'm facing some weird problems in my build, which I am fixing. But I've checked your code and it looks fine to me. You seem to have covered all the datatypes that should be used. Do you want me to test something specifically? |
Hm I just did some testing it seems to run all fine. I guess it's alright. @Orbiter does this need to save for multiple uses? Because right now, if one file is opened multiple times, they all have a own instance of the object in memory and overwrite each other. Or should there be a file (write) lock? |
For #374 we only have one instance each, so I guess i'll leave locks for later |
merged #405 |
we need a json file storage options to store settings in json objects
This is a naive way to do that, but it will do the job
The text was updated successfully, but these errors were encountered: