Save client connection #384
Conversation
demo-implementation for 'hello' servlet
…ads and to enable or disable authentication on downloads. Can be overwritten in config
Redesigned the apps page to matrix style with on-hover display.
Fixes #387 Added Link to the apps page
Updated the apps.md for adding a screenshot
Fixes #331 Added script to start.sh, to read the port value from the config file
of the Post object, which is now in the Query class. This caused that all servlets had to be modified. Now the class AbstractAPIHandler is able to handle user access rights. That class gets an APIServiceLevel object when asked by AbstractAPIHandler for getCustomServiceLevel. Therefore we can handle all authorization tasks at a central place.
class. Started to migrate that with the "Hello" class. This shall be done until all api.client and api.server Classes are moved to appropriate org.loklak.api sub-packages
|
all authentication/authorization rules should be implemented in https://github.com/loklak/loklak_server/blob/master/src/org/loklak/server/AbstractAPIHandler.java which handles this for all servlets. They propagate their authorization rules using https://github.com/loklak/loklak_server/blob/master/src/org/loklak/server/APIHandler.java#L32 I know that this is still an implementation stub. Lets see how we can merge this. I’m afraid your code needs ann adoption to that strategy. |
Updated buildpack URLs after naming convention changes
…ads and to enable or disable authentication on downloads. Can be overwritten in config
…r into saveClientConnection
|
Ah ok. Right now we have code using the download fuctionality independently of AbstractAPIHandler at different places, even in DAO init. Do I get it right that you
1 might be a bit of a hassle at the moment (or unnessecary for this pull request, it could be done in a follow up to make the all the loklak code comply with AbstractAPIHandler), but 2. seems quite important indeed. |
This is a big rewrite of the client connection.
The first commits clean up the code of the ClientConnection and make them work well (actually, the old code did not accept certificates for wrong names, as it was supposed to do)
The later ones implement different download options for peers and non peers as suggested in #351
The config has now three options for httpsclient.trustselfsignedcerts:
This comes with a warning: by making peers the default, everyone behind a ssl-proxy has either to change the config setting or import the proxy cert to her system. I think it's fair to be a little bit more "secure by default"
Whenever downloading from peers now, we have to use
downloadPeersinstead ofdownloadnow.downloadassumes authentication, but can be flagged to be opportunisticPushes assume peers by default, but can explicitly flagged to not do it.
If this is confusing, I can make it more similar.
I hope I got all download calls to peers changed, but ther're some doGet calls I didn't rightly understand. They still use the non peer download.
@Orbiter can you have a look on this later?