Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add south gravity, overlays & uppercasing to loltext #304

Merged
merged 13 commits into from
May 15, 2016
Merged

Add south gravity, overlays & uppercasing to loltext #304

merged 13 commits into from
May 15, 2016

Conversation

Ruxton
Copy link
Contributor

@Ruxton Ruxton commented May 12, 2016

f9dec2cb4ec

948b37a4233

Allows us to get to some real nice looking configurations.

This idea and code is adapted from @levibuzolic's fork that contains hipstertext

The config for these image was this:

loltext:
  enabled: true
  :global:
    :overlay: true
    :overlay_colors:
  :message:
    :color:
    :font: "/Users/ruxton/Library/Fonts/Raleway-Light.ttf"
    :position: C
    :size: 30
    :stroke_color: none
    :uppercase: true
  :sha:
    :color:
    :font: "/Users/ruxton/Library/Fonts/Raleway-Light.ttf"
    :position: S
    :size: 20
    :stroke_color: none
    :uppercase: false

Ruxton added 9 commits May 12, 2016 18:38
 * Fix config problem for default overlay_color
 * Animate stroke width always 1 (2 too thick for small image)
 * Animate pointsize is half of configured size (24 was half of default)
 * Interline spacing is negative, one-fifth of the configured size
@matthutchinson
Copy link
Member

This is awesome! nice work porting on those options. The new styling looks great and your PR looks all good to me too. Only thing is Travis CI seems to be failing on a couple of tests, i'll probably have some time tomorrow to help you out in getting this green before we can merge

Also, for disabling the ClassLength cop, for now just change the metric in our .rubocop_todo.yml config - we're going to revisit all the cops in a future refactor of the whole gem.

💡- @mroth this gives me an idea on 'themes' for lolcommits - applied specifically to the loltext.rb plugin ...

@Ruxton
Copy link
Contributor Author

Ruxton commented May 13, 2016

Yeah I'm not sure how to pass the feature on 1.8/1.9 that is matching the YAML dump.

On 1.8/1.9 the feature spec is adding /m to them and they're single quotes in 1.8/1.9 and always double quotes in 2.0+

@matthutchinson
Copy link
Member

OK, I took a look and managed to get a green build on Travis (all rubies) with these 2 commits;

https://github.com/mroth/lolcommits/commits/south_gravity_and_overlays

The main problem is down to the differences in how YAML represents arrays between the various Rubies.

Can you port them to your changes and push here again, if all is green, then I'll merge your PR and get a gem release out soon.

@Ruxton
Copy link
Contributor Author

Ruxton commented May 15, 2016

👍 done

@matthutchinson
Copy link
Member

Great, merging now 👍 - Thanks again for your PR!

@matthutchinson matthutchinson merged commit b3786fa into lolcommits:master May 15, 2016
@matthutchinson
Copy link
Member

@Ruxton just a quick update to say that yesterday's gem release included this PR (v0.6.6) 👍
Also, before releasing I improved the configure options for loltext a little in this commit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants