Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use isort to keep imports consistent #105

Merged
merged 3 commits into from Sep 17, 2021
Merged

Use isort to keep imports consistent #105

merged 3 commits into from Sep 17, 2021

Conversation

maratori
Copy link
Member

@maratori maratori mentioned this pull request Sep 17, 2021
@codecov-commenter
Copy link

codecov-commenter commented Sep 17, 2021

Codecov Report

Merging #105 (2d5644b) into master (1f0b6b1) will decrease coverage by 0.01%.
The diff coverage is 88.09%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #105      +/-   ##
==========================================
- Coverage   37.44%   37.43%   -0.02%     
==========================================
  Files          67       67              
  Lines        4305     4304       -1     
==========================================
- Hits         1612     1611       -1     
  Misses       2693     2693              
Impacted Files Coverage Δ
lona/command_line/handle_command_line.py 0.00% <0.00%> (ø)
lona/middlewares/lona_messages.py 0.00% <0.00%> (ø)
lona/middlewares/sessions.py 0.00% <0.00%> (ø)
lona/shell/commands/lona_routes.py 0.00% <0.00%> (ø)
lona/shell/commands/lona_views.py 0.00% <0.00%> (ø)
lona/__init__.py 80.00% <100.00%> (ø)
lona/app.py 29.41% <100.00%> (ø)
lona/client_pre_compiler.py 35.55% <100.00%> (ø)
lona/command_line/run_server.py 25.00% <100.00%> (ø)
lona/default_settings.py 100.00% <100.00%> (ø)
... and 16 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1f0b6b1...2d5644b. Read the comment docs.

@fscherf
Copy link
Member

fscherf commented Sep 17, 2021

@maratori Great change! Thanks for that :)

@fscherf fscherf merged commit e461613 into lona-web-org:master Sep 17, 2021
@maratori maratori deleted the isort branch September 17, 2021 19:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants