-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Typo fixes #80
Typo fixes #80
Conversation
Signed-off-by: Florian Scherf <f.scherf@pengutronix.de>
Signed-off-by: Florian Scherf <f.scherf@pengutronix.de>
Signed-off-by: Florian Scherf <f.scherf@pengutronix.de>
Signed-off-by: Florian Scherf <f.scherf@pengutronix.de>
Signed-off-by: Florian Scherf <f.scherf@pengutronix.de>
Signed-off-by: Florian Scherf <f.scherf@pengutronix.de>
Signed-off-by: Florian Scherf <f.scherf@pengutronix.de>
Signed-off-by: Florian Scherf <f.scherf@pengutronix.de>
Codecov Report
@@ Coverage Diff @@
## master #80 +/- ##
=======================================
Coverage 35.25% 35.25%
=======================================
Files 67 67
Lines 4238 4238
=======================================
Hits 1494 1494
Misses 2744 2744
Continue to review full report at Codecov.
|
@@ -1,6 +1,6 @@ | |||
from typing import Tuple, Optional, Dict, Union |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: What was wrong with alphabetical the order?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All other modules use reverse christmas tree ordered imports (long lines before short lines)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wow. Didn't know even about such kind of sorting.
Let's use linter to keep it consistent (in separate PR).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I learned that when i was studying, in a seminar about C. I thought everyone does this, but after some googling i realize its not that common :D (seems to be a linux style guide thing). I think isort is good idea to get it consistent.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've created #105
No description provided.