Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typo fixes #80

Merged
merged 8 commits into from
Sep 12, 2021
Merged

Typo fixes #80

merged 8 commits into from
Sep 12, 2021

Conversation

fscherf
Copy link
Member

@fscherf fscherf commented Sep 11, 2021

No description provided.

Signed-off-by: Florian Scherf <f.scherf@pengutronix.de>
Signed-off-by: Florian Scherf <f.scherf@pengutronix.de>
Signed-off-by: Florian Scherf <f.scherf@pengutronix.de>
Signed-off-by: Florian Scherf <f.scherf@pengutronix.de>
Signed-off-by: Florian Scherf <f.scherf@pengutronix.de>
Signed-off-by: Florian Scherf <f.scherf@pengutronix.de>
Signed-off-by: Florian Scherf <f.scherf@pengutronix.de>
Signed-off-by: Florian Scherf <f.scherf@pengutronix.de>
@codecov-commenter
Copy link

codecov-commenter commented Sep 11, 2021

Codecov Report

Merging #80 (2d04c6e) into master (9cbaf4d) will not change coverage.
The diff coverage is 50.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #80   +/-   ##
=======================================
  Coverage   35.25%   35.25%           
=======================================
  Files          67       67           
  Lines        4238     4238           
=======================================
  Hits         1494     1494           
  Misses       2744     2744           
Impacted Files Coverage Δ
lona/html/abstract_node.py 56.84% <0.00%> (ø)
lona/html/attribute_list.py 89.15% <ø> (ø)
lona/html/node_list.py 60.95% <ø> (ø)
lona/html/text_node.py 56.86% <ø> (ø)
lona/html/widget_data.py 26.66% <ø> (ø)
lona/server.py 20.77% <ø> (ø)
lona/view_loader.py 21.66% <ø> (ø)
lona/view_runtime_controller.py 17.79% <ø> (ø)
lona/protocol.py 51.88% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9cbaf4d...2d04c6e. Read the comment docs.

@@ -1,6 +1,6 @@
from typing import Tuple, Optional, Dict, Union
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: What was wrong with alphabetical the order?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All other modules use reverse christmas tree ordered imports (long lines before short lines)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow. Didn't know even about such kind of sorting.
Let's use linter to keep it consistent (in separate PR).

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I learned that when i was studying, in a seminar about C. I thought everyone does this, but after some googling i realize its not that common :D (seems to be a linux style guide thing). I think isort is good idea to get it consistent.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've created #105

@fscherf fscherf merged commit 0f02eb7 into master Sep 12, 2021
@fscherf fscherf deleted the fscherf/typo-fixes branch September 12, 2021 07:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants