Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fail all replicas if the node is down or the engine is dead during the restore #566

Closed
wants to merge 1 commit into from
Closed

Fail all replicas if the node is down or the engine is dead during the restore #566

wants to merge 1 commit into from

Conversation

shuo-wu
Copy link
Contributor

@shuo-wu shuo-wu commented May 14, 2020

controller: Fail all replicas if the node is down or the engine is de…
b0f0c37 
…ad during the restore

Longhorn longhorn#1270, longhorn#1336, longhorn#1328

Signed-off-by: Shuo Wu <shuo@rancher.com>
@yasker
Copy link
Member

yasker commented May 14, 2020 •
edited

I am not convinced this is the right fix.

  1. Kubernetes node status can be delayed.
  2. Even if the auto-salvage or auto-attach is triggered, we shouldn't able to present a usable volume to the user, which is the case in [BUG] Backup restore succeeds when an instance manager engine crashes and data is NOT available in the restore volume longhorn#1336 . I don't know why it happened.
  3. According to [BUG] DRV stuck in attaching state when restoring is interrupted by rebooting attached node longhorn#1328 (comment) , [BUG] DRV stuck in attaching state when restoring is interrupted by rebooting attached node longhorn#1328 is not related to the engine failure.

@shuo-wu shuo-wu closed this May 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@shuo-wu @yasker