Revert pr-1221 since revert back to softerr/soft mode in https://…
#1549
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…/longhorn#6655 This reverts commit longhorn@1423656 Ref: longhorn/longhorn#6838 Signed-off-by: Roger Yao <roger.yao@suse.com>
|
@roger-ryao Good follow up. |
yangchiu
requested changes
Oct 22, 2023
There was a problem hiding this comment.
@roger-ryao This PR hasn't been merged yet but the test case still passes. Do you know why?
Hi @yangchiu |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…github.com/longhorn/longhorn/issues/6655
This reverts commit 1423656
Ref: longhorn/longhorn#6838