Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TASK] Revert "Disable Automatically Delete Workload Pod when The Volume Is Detached Unexpectedly for RWX volumes" #6838

Closed
derekbit opened this issue Oct 4, 2023 · 2 comments
Closed

[TASK] Revert "Disable Automatically Delete Workload Pod when The Volume Is Detached Unexpectedly for RWX volumes" #6838

derekbit opened this issue Oct 4, 2023 · 2 comments
Assignees
@derekbit @roger-ryao
Labels
area/volume-rwx Volume RWX related backport/1.4.4 backport/1.5.2 kind/task General task request to fulfill another primary request require/qa-review-coverage Require QA to review coverage

Comments

@derekbit
Copy link
Member

derekbit commented Oct 4, 2023

What's the task? Please describe

Revert #5017 since revert back to softerr/soft mode in #6655

Describe the sub-tasks

Additional context
@derekbit derekbit added kind/task General task request to fulfill another primary request area/volume-rwx Volume RWX related labels Oct 4, 2023
@derekbit derekbit self-assigned this Oct 4, 2023
@derekbit derekbit mentioned this issue Oct 4, 2023
Merged
@longhorn-io-github-bot
Copy link

longhorn-io-github-bot commented Oct 4, 2023 •
edited by derekbit

Pre Ready-For-Testing Checklist

  • Where is the reproduce steps/test steps documented?
    The reproduce steps/test steps are at:

  • Does the PR include the explanation for the fix or the feature?

  • Have the backend code been merged (Manager, Engine, Instance Manager, BackupStore etc) (including backport-needed/*)?
    The PR is at

longhorn/longhorn-manager#2195

  • Which areas/issues this PR might have potential impacts on?
    Area: RWX volume
    Issues

This was referenced Oct 4, 2023
Closed
Closed
@innobead innobead added the require/qa-review-coverage Require QA to review coverage label Oct 5, 2023
@roger-ryao roger-ryao self-assigned this Oct 6, 2023
roger-ryao added a commit to roger-ryao/longhorn-tests that referenced this issue Oct 6, 2023
@roger-ryao
Revert pr-1221 since revert back to softerr/soft mode in longhorn…
7f7c4a6 
…/longhorn#6655

This reverts commit longhorn@1423656

Ref: longhorn/longhorn#6838

Signed-off-by: Roger Yao <roger.yao@suse.com>
@roger-ryao roger-ryao mentioned this issue Oct 6, 2023
Merged
@roger-ryao
Copy link

Verified on master-head 20231006

The test steps

  1. Revert the Update test_rwx_delete_share_manager_pod longhorn-tests#1221
  2. execute test case test_rwx.py::test_rwx_delete_share_manager_pod

Result Passed

@w13915984028 w13915984028 mentioned this issue Apr 13, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@derekbit derekbit

@roger-ryao roger-ryao

Labels
area/volume-rwx Volume RWX related backport/1.4.4 backport/1.5.2 kind/task General task request to fulfill another primary request require/qa-review-coverage Require QA to review coverage
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@innobead @derekbit @longhorn-io-github-bot @roger-ryao