Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BACKPORT][v1.5.5][IMPROVEMENT] Expose virtual size of qcow2 backing images #8321

Closed
github-actions bot opened this issue Apr 9, 2024 · 2 comments
Closed
Assignees
Labels
kind/backport Backport request kind/improvement Request for improvement of existing function priority/0 Must be fixed in this release (managed by PO) require/backport Require backport. Only used when the specific versions to backport have not been definied. require/doc Require updating the longhorn.io documentation require/manual-test-plan Require adding/updating manual test cases if they can't be automated
Milestone

Comments

@github-actions
Copy link

github-actions bot commented Apr 9, 2024

backport #7923

@github-actions github-actions bot added kind/backport Backport request kind/improvement Request for improvement of existing function priority/0 Must be fixed in this release (managed by PO) require/backport Require backport. Only used when the specific versions to backport have not been definied. require/doc Require updating the longhorn.io documentation require/manual-test-plan Require adding/updating manual test cases if they can't be automated labels Apr 9, 2024
@github-actions github-actions bot added this to the v1.5.5 milestone Apr 9, 2024
@chriscchien chriscchien self-assigned this Apr 9, 2024
@longhorn-io-github-bot
Copy link

longhorn-io-github-bot commented Apr 9, 2024

Pre Ready-For-Testing Checklist

  1. Create a raw backing image and run kubectl -n longhorn-system get lhbi <backing image name>. Then varify if Size == VirtualSize
  2. Create a qcow2 backing image and run kubectl -n longhorn-system get lhbi <backing image name>. Then varify if Size can be different from VirtualSize

@chriscchien
Copy link
Contributor

Verified pass on longhorn v1.5.x (longhorn-manager 34d22c, backing-image-manager 4b6088) with test steps

Create backing images

  • qcow2 from https://longhorn-backing-image.s3-us-west-1.amazonaws.com/parrot.qcow2
  • raw from https://longhorn-backing-image.s3-us-west-1.amazonaws.com/parrot.raw

Thw raw backing image's size equal to virtualsize

> kubectl -n longhorn-system get lhbi raw -o yaml | grep size -A2
  size: 33554432
  uuid: 2a4e00f8
  virtualSize: 33554432

Thw qcow2 backing image's size not equal to virtualsize

> kubectl -n longhorn-system get lhbi qcow2 -o yaml | grep size -A2
  size: 1161728
  uuid: e038860f
  virtualSize: 33554432

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/backport Backport request kind/improvement Request for improvement of existing function priority/0 Must be fixed in this release (managed by PO) require/backport Require backport. Only used when the specific versions to backport have not been definied. require/doc Require updating the longhorn.io documentation require/manual-test-plan Require adding/updating manual test cases if they can't be automated
Projects
None yet
Development

No branches or pull requests

3 participants