Expose virtual size of qcow2 backing images (backport #208) #223
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When doing local builds (i.e. without $DRONE_REPO and $DRONE_PULL_REQUEST,
or $DRONE_COMMIT_REF set), the build fails with "fatal: Needed a single
revision" in `scripts/validate`:
```
> make REPO=tserong
[...]
Running validation
Running: go vet
refs/heads/wip-add-virtualSize
fatal: Needed a single revision
FATA[0032] exit status 128
make: *** [Makefile:11: ci] Error 1
```
If I run the commands in `scripts/validate` by hand, I see this:
```
> git symbolic-ref -q HEAD && REV="origin/HEAD" || REV="HEAD^"
refs/heads/wip-add-virtualSize
> echo $REV
origin/HEAD
> headSHA=$(git rev-parse --short=12 ${REV})
fatal: Needed a single revision
```
I don't know if this is just something weird about my environment, but
if I change "origin/HEAD" to "HEAD", it works fine:
```
> headSHA=$(git rev-parse --short=12 HEAD)
> echo $headSHA
eb27fbf6e678
```
Signed-off-by: Tim Serong <tserong@suse.com>
(cherry picked from commit 6841c08)
This commit adds VirtualSize to the BackingImage, BackingImageStatus, BackingImageSpec and FileInfo structs. This will allow longhorn-manager to in turn pick up the virtual image size and expose it in the status section of the BackingImage and BackingImageManager CRDs. The virtual size of an image is determined by running `qemu-img info`. For qcow2 images, the virtual size will usually be larger than the actual physical file size. For raw images, `qemu-img info` still reports virtual size, but it's the same as the physical file size in this case. It's important to note that we can only report the virtual size of an image once the syncing file is ready. If the syncing file is not yet ready (or if for some reason the call to `qemu-img info` fails), virtual size will be set to zero. Related issue: longhorn/longhorn#7923 Signed-off-by: Tim Serong <tserong@suse.com> (cherry picked from commit ceb51fd)
shuo-wu
force-pushed
the
mergify/bp/v1.5.x/pr-208
branch
from
752027e
to
337f3a8
Compare
Signed-off-by: Tim Serong <tserong@suse.com> (cherry picked from commit c5288d7) Signed-off-by: Shuo Wu <shuo.wu@suse.com>
shuo-wu
force-pushed
the
mergify/bp/v1.5.x/pr-208
branch
from
337f3a8
to
f6e7b24
Compare
innobead
approved these changes
Apr 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes conflicts for #220