-
Notifications
You must be signed in to change notification settings - Fork 584
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OCP / OKD Documentation and Helm Support #5004
Conversation
Signed-off-by: Bin Guo <bin.guo@casa-systems.com>
Signed-off-by: Bin Guo <bin.guo@casa-systems.com>
Signed-off-by: Bin Guo <bin.guo@casa-systems.com>
Signed-off-by: Arthur <arthur@arthurvardevanyan.com>
Signed-off-by: Arthur <arthur@arthurvardevanyan.com>
@ArthurVardevanyan it seems you are active on OKD deployment, so do you want to own #1831? |
Signed-off-by: Arthur <arthur@arthurvardevanyan.com>
Signed-off-by: Arthur <arthur@arthurvardevanyan.com>
Signed-off-by: Arthur <arthur@arthurvardevanyan.com>
Signed-off-by: Arthur <arthur@arthurvardevanyan.com>
2ec3dba
to
ffa68a6
Compare
Signed-off-by: Arthur <arthur@arthurvardevanyan.com>
8a96c19
to
a8b6186
Compare
4.11.0-0.okd-2022-11-19-050030 [Longhorn 1.3.2]Their may be some noise, this a long-lasting cluster. 4.12.0-0.okd-2022-12-11-164611 [Longhorn 1.4.0.-dev]Their might be some noise from a rolling reboot. - kind: ServiceAccount
name: default # supportbundle-agent-support-bundle daemonset doesn't use a dedicated service account.
namespace: {{ include "release_namespace" . }} supportbundle_19d7497d-0deb-425a-990d-a2a6e367b09e_2022-12-11T23-17-27Z.zip |
Sure, No Preference either way. This PR should be good to take a look at. It covers the basic use cases. |
Signed-off-by: Arthur <arthur@arthurvardevanyan.com>
ea7d6cf
to
480859f
Compare
Signed-off-by: Arthur <arthur@arthurvardevanyan.com>
480859f
to
734e288
Compare
Signed-off-by: Arthur <arthur@arthurvardevanyan.com>
Signed-off-by: Arthur <arthur@arthurvardevanyan.com>
@mantissahz Please help review this PR and work with @ArthurVardevanyan . Thanks. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In general LGTM
chart/values.yaml
Outdated
# finalizers: true | ||
# privileged: true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we set these to true by default once openshift
is enabled?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
@ArthurVardevanyan could you please try to resolve the conversions? I had verified the PR on OKD 4.14 environment.
helm template longhorn --namespace longhorn-system --values values.yaml --no-hooks > longhorn.yaml
oc create namespace longhorn-system -o yaml --dry-run=client | oc apply -f -
oc apply -f longhorn.yaml -n longhorn-system |
Signed-off-by: Arthur <arthur@arthurvardevanyan.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In general, LGTM.
Please fix the remaining comments. Thanks.
name: longhorn-ui-service-account | ||
namespace: {{ include "release_namespace" . }} | ||
- kind: ServiceAccount | ||
name: default # supportbundle-agent-support-bundle uses default sa |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cc @c3y1huang , maybe we should pass the service account to the support bundle manager, and it can use it for the agent pod creation as well.
After that, we can remove this binding.
@mantissahz Please help re-verify this PR after @ArthurVardevanyan resolves the comments. Thanks. |
Signed-off-by: Arthur <arthur@arthurvardevanyan.com>
… into okd-ocp Signed-off-by: Arthur <arthur@arthurvardevanyan.com>
b3cbf1a
to
fa16549
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@ArthurVardevanyan I would like to have you help with the following contribution for OCP/OKD support to make sure it's sustained. Thanks first. @mantissahz Please move forward with the QA process. Thanks. |
* Add OCP support to helm chart. Signed-off-by: Bin Guo <bin.guo@casa-systems.com> Signed-off-by: Arthur <arthur@arthurvardevanyan.com> Co-authored-by: Bin Guo <bin.guo@casa-systems.com> Co-authored-by: David Ko <dko@suse.com> Co-authored-by: binguo-casa <70552879+binguo-casa@users.noreply.github.com>
Picking up where: #2909 left off.
Related Issue: #1831
Been using Longhorn on my OKD HomeLab Since OKD/OCP 4.10/1.23
Since these Launches are around the corner, targeting:
Main Modifications from Previous PR:
Testing:
Non-OKD/OCP Changes
Switched UI Deployment from default service-account to custom service account