OCP / OKD Documentation and Helm Support

[ArthurVardevanyan]

Picking up where: #2909 left off.

Related Issue: #1831

Been using Longhorn on my OKD HomeLab Since OKD/OCP 4.10/1.23

Since these Launches are around the corner, targeting:

• OCP: 4.12 / 1.25 & 4.13 / 1.26
• Longhorn 1.4.0 / 1.5.0

Main Modifications from Previous PR:

• Removed Extra(?) Mount Points to Daemonset
• Converted Policy Commands to Yaml Cluster Role RBAC
• Removed ISCSI Setup as this is handled already by RHCOS/FCOS
• General Documentation Updates

Testing:

• 4.10 / 1.23:
  • 4.10.0-0.okd-2022-03-07-131213 to 4.10.0-0.okd-2022-07-09-073606: Tested, No Known Issues (Previously Used Versions)
• 4.11 / 1.24:
  • 4.11.0-0.okd-2022-07-27-052000 to 4.11.0-0.okd-2022-11-19-050030: Tested, No Known Issues
  • 4.11.0-0.okd-2022-12-02-145640:
    • Workaround: [BUG] Volumes Stuck in Attach/Detach Loop
• 4.12 / 1.25:
  • 4.12.0-0.okd-2022-12-05-210624 to 4.12.0-0.okd-2022-12-11-164611: Tested, No Known Issues

Non-OKD/OCP Changes

Switched UI Deployment from default service-account to custom service account

[innobead]

@ArthurVardevanyan it seems you are active on OKD deployment, so do you want to own #1831?

[ArthurVardevanyan]

4.11.0-0.okd-2022-11-19-050030 [Longhorn 1.3.2]

Their may be some noise, this a long-lasting cluster.
longhorn-support-bundle_00e45f14-1554-4313-bb2b-27dbf74ab4c7_2022-12-11T22-25-07Z.zip

4.12.0-0.okd-2022-12-11-164611 [Longhorn 1.4.0.-dev]

Their might be some noise from a rolling reboot.
New Support Bundle Feature still isn't complete:
Temporary Workaround, didn't include in the chart, since the final service account is unknown at this time.

- kind: ServiceAccount
  name: default # supportbundle-agent-support-bundle daemonset doesn't use a dedicated service account.
  namespace: {{ include "release_namespace" . }}

supportbundle_19d7497d-0deb-425a-990d-a2a6e367b09e_2022-12-11T23-17-27Z.zip

[ArthurVardevanyan]

@ArthurVardevanyan it seems you are active on OKD deployment, so do you want to own #1831?

Sure, No Preference either way.
I have no plans to stop using Longhorn + OKD

This PR should be good to take a look at. It covers the basic use cases.

[innobead]

@mantissahz Please help review this PR and work with @ArthurVardevanyan . Thanks.

[mantissahz]

In general LGTM

[shuo-wu]

Should we set these to true by default once openshift is enabled?

[ArthurVardevanyan]

Done

[mantissahz]

@ArthurVardevanyan could you please try to resolve the conversions?

I had verified the PR on OKD 4.14 environment.
By the steps in README.md (chart/ocp-readme.md):

1. Label nodes
2. Create a file system and the mount point for disks on nodes
3. Create a deploying manifest file from Helm by commands

helm template longhorn --namespace longhorn-system --values values.yaml --no-hooks  > longhorn.yaml
oc create namespace longhorn-system -o yaml --dry-run=client | oc apply -f -
oc apply -f longhorn.yaml -n longhorn-system

[innobead]

In general, LGTM.

Please fix the remaining comments. Thanks.

[innobead]

cc @c3y1huang , maybe we should pass the service account to the support bundle manager, and it can use it for the agent pod creation as well.

After that, we can remove this binding.

[innobead]

@mantissahz Please help re-verify this PR after @ArthurVardevanyan resolves the comments. Thanks.

[innobead]

LGTM

[innobead]

@ArthurVardevanyan I would like to have you help with the following contribution for OCP/OKD support to make sure it's sustained. Thanks first.

@mantissahz Please move forward with the QA process. Thanks.