Check cache fc_version.h at configure time #1638
Conversation
|
I'm afraid that this will trigger a full rebuild after every local commit, which is definitely too much, but maybe I misremember what we put in the version string? |
I didn't test that scenario. Let me see what happens. |
|
It works while you are working on a bunch of local changes. Multiple commits are fine in a branch while you are working. You might run into an issue if you switch to a different branch that has a diff hash from master branch, that will force a "mostly" recompile, but not a total recompile. The code is essentially getting the current hash turned into a integer from the last pull, so based on what that is in the branch you are working on would cause a recompile. I think this better than ignoring it altogether like we did in the past. One recompile with a fresh |
I switch between branches all the time, so this will slow me down significantly :( I think we keep this out for now and revisit after 3.0 is out, moving the info to a file that gets compiled exactly once (and fast). |
|
Yea I was thinking something about that too. I wonder if it would be better to check the tag and do the removal of the cached file when a new tag is done. That would be a more rare event and allow branch switching. |
For devs who do not clean their cache directory often, we do a check for the generated fc_version.h and if the patch version is different then we delete the cache file. Closes longturn#1564
This makes for a simpler implementation and is also more general: a change in the network capstring will also trigger a rebuild of the relevant parts of the code. See longturn#1638.
lmoureaux
force-pushed
the
bugfix/version-check
branch
from
69a9def
to
6f87f25
Compare
Instead of including in every single source file through fc_config.h, selectively include it where it's needed. Changing the version used to trigger a full rebuild, now only two dozens files are rebuilt. See longturn#1564.
This makes for a simpler implementation and is also more general: a change in the network capstring will also trigger a rebuild of the relevant parts of the code. See longturn#1638.
lmoureaux
force-pushed
the
bugfix/version-check
branch
from
6f87f25
to
b5a78d4
Compare
For devs who do not clean their cache directory often, we do a check for the generated
fc_version.hand if the patch version is different then we delete the cache file. Closes #1564