Don't refresh the whole map with every change to a city #1788
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The refresh had been introduced to highlight the correct tiles when switching city from the city dialog. Detect such changes and refresh the relevant working areas only. This improves performance of city management dramatically when using small tilesets or large windows. Reported by Corbeau on Discord.
jwrober
approved these changes
Jan 29, 2023
lmoureaux
added a commit
to lmoureaux/freeciv21
that referenced
this pull request
Jan 30, 2023
Use the generic setup_ui function instead of duplicating its code in get_city. See longturn#1788.
jwrober
pushed a commit
that referenced
this pull request
Jan 30, 2023
Use the generic setup_ui function instead of duplicating its code in get_city. See #1788.
lmoureaux
added a commit
that referenced
this pull request
Feb 2, 2023
Use the generic setup_ui function instead of duplicating its code in get_city. See #1788.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The refresh had been introduced to highlight the correct tiles when switching city from the city dialog. Detect such changes and refresh the relevant working areas only.
This improves performance of city management dramatically when using small tilesets or large windows.
Reported by Corbeau on Discord.
Testing:
Suggest to backport.