Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use native compression tools instead of git archive for releases #2256

Merged
merged 4 commits into from
Mar 31, 2024

Conversation

jwrober
Copy link
Collaborator

@jwrober jwrober commented Mar 31, 2024

Closes #2179

@jwrober jwrober requested a review from blabber March 31, 2024 20:56
@lmoureaux
Copy link
Contributor

Does this exclude the same files as git-archive? Packaging the whole data results in quite heavy tarballs

@jwrober
Copy link
Collaborator Author

jwrober commented Mar 31, 2024

You get ~100mb files. I can add more excludes if needed. What in data do we not want to ship?

@jwrober
Copy link
Collaborator Author

jwrober commented Mar 31, 2024

I pulled data/graphics out. Now the archives are around 50mb

@jwrober
Copy link
Collaborator Author

jwrober commented Mar 31, 2024

@lmoureaux
Copy link
Contributor

These are the export-ignore from .gitattributes:

# don't export these files
data/graphics/**    export-ignore
.coverity/**        export-ignore
.github/**          export-ignore
.gitlab-ci.yaml     export-ignore
.readthedocs.yaml   export-ignore

@lmoureaux
Copy link
Contributor

An alternative approach would be to commit the autorevision changes and keep using git archive

@jwrober
Copy link
Collaborator Author

jwrober commented Mar 31, 2024

We get all of those w/ git archive too, so I don't see an issue there.

@jwrober
Copy link
Collaborator Author

jwrober commented Mar 31, 2024

My solution doesn't pull those in.

@lmoureaux
Copy link
Contributor

Interesting 😂 I see .coverity (empty dir) and .gitlab-ci.yml in the latest tarball, but not the other two.
With your solution we don't package any hidden file, which works as well

@jwrober
Copy link
Collaborator Author

jwrober commented Mar 31, 2024

I did see an issue in the zip file. Since it runs after the gz creating it also pulls in the sha file. I'll push a fix

@jwrober jwrober merged commit 2ffe2ae into longturn:master Mar 31, 2024
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Release workflow: Wrong version in AutoRevision.txt for v3.0-patch.3
2 participants