Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release workflow: Wrong version in AutoRevision.txt for v3.0-patch.3 #2179

Closed
blabber opened this issue Jan 27, 2024 · 3 comments · Fixed by #2256
Closed

Release workflow: Wrong version in AutoRevision.txt for v3.0-patch.3 #2179

blabber opened this issue Jan 27, 2024 · 3 comments · Fixed by #2256
Assignees
Labels
bug Something isn't working tools Issues related to mp, ruledit, etc along with CI and build tools.
Milestone

Comments

@blabber
Copy link
Collaborator

blabber commented Jan 27, 2024

Describe the bug
The release source archive for v3.0-patch.3 contains the following:

cat Freeciv21-v3.0-patch.3/cmake/AutoRevision.txt
f5eab4
v3.0-patch.2

To Reproduce

Expected behavior
AutoRevision.txt should contain the correct information, like the file content committed in 4c161dc:

e5a21
v3.0-patch.3

Platform and version (please complete the following information):

  • OS: FreeBSD 14.0
  • Freeciv21 version: 3.0-patch.3
@blabber blabber added bug Something isn't working Untriaged This issue or PR needs triaging labels Jan 27, 2024
@jwrober jwrober added tools Issues related to mp, ruledit, etc along with CI and build tools. and removed Untriaged This issue or PR needs triaging labels Jan 27, 2024
@jwrober
Copy link
Collaborator

jwrober commented Jan 27, 2024

The code that does this work is here - https://github.com/longturn/freeciv21/blob/master/.github/workflows/release.yaml

@blabber
Copy link
Collaborator Author

blabber commented Jan 27, 2024

The debug output of the workflow action displays the correct file contents (check step "Run cat cmake/AutoRevision.txt"). That makes this issue even more mysterious.

https://github.com/longturn/freeciv21/actions/runs/7602889261/job/20703953195

@lmoureaux
Copy link
Contributor

This is because we run git archive without committing the new AutoRevision file:

git archive --format=tar.gz --prefix=Freeciv21-v3.0-patch.3/ -o $PWD/build/Freeciv21-v3.0-patch.3.tar.gz HEAD

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working tools Issues related to mp, ruledit, etc along with CI and build tools.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants