Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove the minimap thread. #886

Merged
merged 1 commit into from
Feb 11, 2022
Merged

Remove the minimap thread. #886

merged 1 commit into from
Feb 11, 2022

Conversation

zekoz
Copy link
Contributor

@zekoz zekoz commented Feb 9, 2022

Removes zooming and panning of minimap view, but adds wraparound for viewport rectangle.

@zekoz zekoz requested a review from lmoureaux February 9, 2022 13:25
lmoureaux
lmoureaux requested changes Feb 10, 2022
View reviewed changes
Copy link
Contributor

@lmoureaux lmoureaux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Artifacts accumulate along the edges (WRAPX|WRAPY|HEX):
image

A stupidly small map or sufficient zooming out can give this result:
image

client/gui-qt/minimap.cpp Show resolved Hide resolved
@zekoz
Remove the minimap thread.
a54500b 
Removes zooming and panning of minimap view, but adds wraparound for viewport rectangle.
@zekoz zekoz requested a review from lmoureaux February 11, 2022 13:26
@lmoureaux lmoureaux merged commit cca08d2 into longturn:master Feb 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lmoureaux lmoureaux lmoureaux approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zekoz @lmoureaux