Re-work the filters & Set the route name for routing in config #444

mjamilasfihani · 2021-09-25T13:43:07Z

Fix issue #443

MGatner

See my comment on the issue, but this should be refactored with url_is() and route_to(), not relying on the App Config directly.

mjamilasfihani · 2021-09-26T18:06:06Z

hang in there

mjamilasfihani · 2021-09-26T19:09:55Z

I removed the helper('auth') and use loop to check the current url, in case if user has change their route name they just change the array. is it okay?

use `uri_string()` to get the string from current url

I use `current_url()` and at line 51 I add an extra script in case if user use index.php :)

mjamilasfihani · 2021-09-26T20:11:45Z

if we use the CI version start from v4.0.5 the function url_is() is available, but if we end the support for < v4.0.5 I can just use url_is()

NOTE : Since url_is() is available start from CodeIgniter 4.0.5, user must update their application.

mjamilasfihani · 2021-09-27T15:29:39Z

now we can use login filter in global :)

I remove the helper('auth) since it's no use in there (performance reason) and put the session check at the begin of code, because we need a session data right?

src/Filters/LoginFilter.php

src/Filters/PermissionFilter.php

src/Filters/RoleFilter.php

MGatner · 2021-09-28T11:31:26Z

Looking better! A few changes. Also please be sure to run the style fixer.

mjamilasfihani · 2021-09-28T17:52:18Z

Wait for a moment, I'll fix it

mjamilasfihani · 2021-10-03T11:22:36Z

How about this PR @MGatner ? Any suggestion for the code position?

MGatner · 2021-10-03T12:28:02Z

It's too bulky for me to do on mobile, been waiting for a chance on desktop! From what I can see it looks right. I also want to check why tests are failing - I think it is unrelated to this PR.

mjamilasfihani · 2021-10-04T16:32:32Z

Okay, I hope it'll fix soon

mjamilasfihani · 2021-10-27T01:32:07Z

Hello @MGatner how the PHPStan's status? Still not working?

MGatner · 2021-10-30T12:02:04Z

The PHPStan issues aren't related to this PR - probably an update to the tool itself caused this. I'm good with this change! @lonnieezell last look?

mjamilasfihani · 2021-10-30T17:38:50Z

@MGatner I am happy to hear that :)

MGatner

Okay I made a proper review this time! A few suggestions to clean up and make this a legit refactor 😉

src/Filters/LoginFilter.php

src/Filters/RoleFilter.php

mjamilasfihani · 2021-10-31T12:04:38Z

Okay I made a proper review this time! A few suggestions to clean up and make this a legit refactor 😉

Thanks for the review, I will try to figure it :)

it's funny, I just learned about abstract class and you give that suggestion 😂

lonnieezell · 2021-11-01T03:32:31Z

I have no problems with this PR, I think. I agree with @MGatner latest comments so go ahead and address those, though.

mjamilasfihani · 2021-11-03T20:13:18Z

fix #453

I add defaultLandingRoute to store the default route name after user success to login (depend on the real case) or fail in Permission & Role Filters too

src/Config/Auth.php

sorry my mistake

mjamilasfihani · 2021-11-18T16:18:36Z

Any idea how I fail all the test :( @MGatner

MGatner · 2021-11-19T15:43:36Z

@mjamilasfihani This repos tests might be borked. I would like to switch the CI/CD to the new CodeIgniter Dev Kit which hopefully will be ready today or tomorrow.

mjamilasfihani · 2021-11-19T15:48:44Z

That's good. Anytime you can do it @MGatner

MGatner · 2022-04-27T20:23:43Z

Hi @mjamilasfihani - a 5-month hiatus, but I am almost ready to merge the DevKit updates. Are you around to rebase this and clean up any changes for a final review once #517 is in?

mjamilasfihani · 2022-04-27T20:56:34Z

Thanks @MGatner for the good news, I'm ready for this 🔥

…to lonnieezell-develop

Lonnieezell develop

The Routes.php now will use reserved routing from Auth.php

MGatner

This is looking good! Please add some tests. The framework now has the FilterTestTrait which makes it easy to test filters.

src/Config/Auth.php

Update LoginFilter.php

cf703ad

MGatner requested changes Sep 26, 2021

View reviewed changes

mjamilasfihani and others added 2 commits September 27, 2021 01:06

Merge branch 'lonnieezell:develop' into develop

9ff7d8f

Update LoginFilter.php

59da7a8

Update LoginFilter.php

cd2536f

use `uri_string()` to get the string from current url

mjamilasfihani requested a review from MGatner September 26, 2021 19:40

mjamilasfihani added 2 commits September 27, 2021 03:04

uri_string is a bad idea

837ef6d

I use `current_url()` and at line 51 I add an extra script in case if user use index.php :)

Update LoginFilter.php

9cfdcf9

use url_is() function for better solution

d653285

NOTE : Since url_is() is available start from CodeIgniter 4.0.5, user must update their application.

a little re work for another filters

6922b14

I remove the helper('auth) since it's no use in there (performance reason) and put the session check at the begin of code, because we need a session data right?

MGatner requested changes Sep 28, 2021

View reviewed changes

fix

1c4cf54

mjamilasfihani requested a review from MGatner September 30, 2021 13:34

mjamilasfihani changed the title ~~Update LoginFilter.php~~ Re-work the filters Sep 30, 2021

Update PermissionFilter.php

25b4199

MGatner requested changes Oct 31, 2021

View reviewed changes

src/Filters/LoginFilter.php Outdated Show resolved Hide resolved

src/Filters/LoginFilter.php Outdated Show resolved Hide resolved

src/Filters/RoleFilter.php Outdated Show resolved Hide resolved

mjamilasfihani changed the title ~~Re-work the filters~~ Re-work the filters & Pre-Config for Routing Nov 3, 2021

mjamilasfihani mentioned this pull request Nov 3, 2021

Problem to create custom Routing #453

Closed

mjamilasfihani changed the title ~~Re-work the filters & Pre-Config for Routing~~ Re-work the filters & Set the route name for routing in config Nov 3, 2021

mjamilasfihani added 2 commits November 5, 2021 07:46

Candidate for BaseFilter & the reserved routes

ff02bb8

I add defaultLandingRoute to store the default route name after user success to login (depend on the real case) or fail in Permission & Role Filters too

Candidate for the new Filters

129bcab

mjamilasfihani commented Nov 5, 2021

View reviewed changes

src/Config/Auth.php Show resolved Hide resolved

mjamilasfihani commented Nov 5, 2021

View reviewed changes

src/Config/Auth.php Outdated Show resolved Hide resolved

mjamilasfihani added 3 commits November 11, 2021 13:51

Update BaseFilter.php

5b316c7

extend the BaseFilter

9b1d771

sorry my mistake

rename $defaultLandingRoute to $landingRoute

9c2931b

just rename some strings

2d8a6c6

MGatner closed this Apr 27, 2022

MGatner reopened this Apr 27, 2022

mjamilasfihani added 3 commits July 1, 2022 07:27

Merge branch 'develop' of https://github.com/lonnieezell/myth-auth in…

a1d07de

…to lonnieezell-develop

Merge pull request #2 from mjamilasfihani/lonnieezell-develop

782ac1d

Lonnieezell develop

Run CodeIgniter4 Coding Standards

8babd47

mjamilasfihani requested a review from MGatner July 1, 2022 01:01

Update Routes.php

44bb889

The Routes.php now will use reserved routing from Auth.php

MGatner requested changes Jul 8, 2022

View reviewed changes

src/Config/Auth.php Outdated Show resolved Hide resolved

MGatner added 3 commits July 12, 2022 19:43

Merge remote-tracking branch 'origin/develop' into refactor-filters

ab68723

Fix typo

1a4ddf5

Apply analysis fixes

0dd5766

MGatner merged commit 100822e into lonnieezell:develop Jul 12, 2022

MGatner mentioned this pull request Jul 13, 2022

Controller Name #546

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Re-work the filters & Set the route name for routing in config #444

Re-work the filters & Set the route name for routing in config #444

mjamilasfihani commented Sep 25, 2021

MGatner left a comment

mjamilasfihani commented Sep 26, 2021

mjamilasfihani commented Sep 26, 2021

mjamilasfihani commented Sep 26, 2021 •

edited

Loading

mjamilasfihani commented Sep 27, 2021

MGatner commented Sep 28, 2021

mjamilasfihani commented Sep 28, 2021

mjamilasfihani commented Oct 3, 2021

MGatner commented Oct 3, 2021

mjamilasfihani commented Oct 4, 2021

mjamilasfihani commented Oct 27, 2021

MGatner commented Oct 30, 2021

mjamilasfihani commented Oct 30, 2021

MGatner left a comment

mjamilasfihani commented Oct 31, 2021

lonnieezell commented Nov 1, 2021

mjamilasfihani commented Nov 3, 2021

mjamilasfihani commented Nov 18, 2021

MGatner commented Nov 19, 2021

mjamilasfihani commented Nov 19, 2021

MGatner commented Apr 27, 2022

mjamilasfihani commented Apr 27, 2022

MGatner left a comment

Re-work the filters & Set the route name for routing in config #444

Re-work the filters & Set the route name for routing in config #444

Conversation

mjamilasfihani commented Sep 25, 2021

MGatner left a comment

Choose a reason for hiding this comment

mjamilasfihani commented Sep 26, 2021

mjamilasfihani commented Sep 26, 2021

mjamilasfihani commented Sep 26, 2021 • edited Loading

mjamilasfihani commented Sep 27, 2021

MGatner commented Sep 28, 2021

mjamilasfihani commented Sep 28, 2021

mjamilasfihani commented Oct 3, 2021

MGatner commented Oct 3, 2021

mjamilasfihani commented Oct 4, 2021

mjamilasfihani commented Oct 27, 2021

MGatner commented Oct 30, 2021

mjamilasfihani commented Oct 30, 2021

MGatner left a comment

Choose a reason for hiding this comment

mjamilasfihani commented Oct 31, 2021

lonnieezell commented Nov 1, 2021

mjamilasfihani commented Nov 3, 2021

mjamilasfihani commented Nov 18, 2021

MGatner commented Nov 19, 2021

mjamilasfihani commented Nov 19, 2021

MGatner commented Apr 27, 2022

mjamilasfihani commented Apr 27, 2022

MGatner left a comment

Choose a reason for hiding this comment

mjamilasfihani commented Sep 26, 2021 •

edited

Loading