CodeIgniter DevKit #517
Merged
CodeIgniter DevKit #517
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MGatner
force-pushed
the
tools-devkit
branch
2 times, most recently
from
85986b5
to
c4f01e5
Compare
This was referenced Apr 27, 2022
MGatner
force-pushed
the
tools-devkit
branch
2 times, most recently
from
97e10e2
to
fd472e4
Compare
|
I'll be honest - I'm not going to read all 112 files on this one. I'm just going to say "I trust you" lol |
|
Haha thanks for the vote of confidence! Most of that is just updating the coding standard. The only "content" is in the last three commits, and especially the "Consolidate..." which was only partially-necessary to resolve the static analysis issues. Honestly though just having workflows working as a new baseline should make anything else 10x easier moving forward. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are a few big "gotchas" that I have created issues for (#515, #516). Two
LoginTestcases are failing local that need looking into, but pushing this so the updated workflows can run.Note: This commits firmly to PHP
^7.4 || ^8.0Supersedes #452, #500, #505