PostgreSQL support - proposal n.2: change tinyint to bools in database schema #495
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(on top of the run with SQLite)
This patch allows Myth:Auth to support all three of SQLite, MariaDB and PostgreSQL. - change 'tinyint' to 'boolean' on the migration, - switch 0/1 to true/false coherently throughout the code. Fix lonnieezell#324
|
I will let @lonnieezell handle this one, but at the very least I think the database change should be an additional migration file rather than modifying the current one. |
|
Noted. Actually, the more I think about it, the less I'm convinced this is the way to go. It would be nice to have boolean fields being actual boolean types, but the difference between the DB storing as Ping me if you'd like to see more, but I'll probably close it soon and focus on #494 otherwise. |
|
I think focusing on #493 is probably the better route here. Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull-request is a little more ambitious than #494 as it changes the database schema. The code change is bigger and more likely to introduce breaking scenario, but since MySQL & MariaDB implictly convert booleans fields to tinyint and since SQLite isn't strongly typed, the impact on existing deployments may still be acceptable.
Those patch set up a new casting class, taking care of the strange behaviour of PDO/PostgreSQL fetching
TRUE/FALSEvalues as(string)'t'/(string)'f'by default. For now, this patch is still a work in progress as I would prefer and still hope to usePDO::PARAM_*.Like #494 :