Issue in Reset Password with database postgre #324
Labels
Comments
xlii-chl
added a commit
to xlii-chl/myth-auth
that referenced
this issue
Feb 19, 2022
xlii-chl
added a commit
to xlii-chl/myth-auth
that referenced
this issue
Feb 19, 2022
xlii-chl
added a commit
to xlii-chl/myth-auth
that referenced
this issue
Feb 22, 2022
…ict DB This patch doesn't modify the database schema and, instead, forcibly converts booleans to integers. Another way of fixing lonnieezell#324 would be to use booleans at the database level : the code change is bigger but, since MySQL & MariaDB would implictly convert to tinyint and SQLite isn't typed, the impact on existing deployments may still be acceptable.
xlii-chl
added a commit
to xlii-chl/myth-auth
that referenced
this issue
Feb 22, 2022
This patch allows Myth:Auth to support all three of SQLite, MariaDB and PostgreSQL. - change 'tinyint' to 'boolean' on the migration, - switch 0/1 to true/false coherently throughout the code. Fix lonnieezell#324
|
As a reference, I'll add links to the 2 pull-requests in review for this bug : |
xlii-chl
added a commit
to xlii-chl/myth-auth
that referenced
this issue
Feb 25, 2022
As PostgreSQL is strongly typed and doesn't have an implicit cast between booleans and integers, we strictly use integers for the force_pass_reset field.
xlii-chl
added a commit
to xlii-chl/myth-auth
that referenced
this issue
Feb 25, 2022
As PostgreSQL is strongly typed and doesn't have an implicit cast between booleans and integers, we strictly use integers for the force_pass_reset field.
xlii-chl
added a commit
to xlii-chl/myth-auth
that referenced
this issue
Feb 26, 2022
As PostgreSQL is strongly typed and doesn't have an implicit cast between booleans and integers, we strictly use integers for the force_pass_reset field.
xlii-chl
added a commit
to xlii-chl/myth-auth
that referenced
this issue
Apr 29, 2022
…ict DB This patch doesn't modify the database schema and, instead, forcibly converts booleans to integers. Another way of fixing lonnieezell#324 would be to use booleans at the database level : the code change is bigger but, since MySQL & MariaDB would implictly convert to tinyint and SQLite isn't typed, the impact on existing deployments may still be acceptable.
xlii-chl
added a commit
to xlii-chl/myth-auth
that referenced
this issue
Apr 29, 2022
…ict DB This patch doesn't modify the database schema and, instead, forcibly converts booleans to integers. Another way of fixing lonnieezell#324 would be to use booleans at the database level : the code change is bigger but, since MySQL & MariaDB would implictly convert to tinyint and SQLite isn't typed, the impact on existing deployments may still be acceptable.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
UPDATE "users" SET "password_hash" = '$2y$10$30Whf9ceEJfPA2l6SRlM3OWRadjcNuaUIdMAgz4TdcKEooPF2ds26', "reset_hash" = NULL, "reset_at" = '2021-03-01 21:55:11', "reset_expires" = NULL, "force_pass_reset" = '', "updated_at" = '2021-03-01 21:55:11' WHERE "users"."id" IN ('1')
issue in "force_pass_reset" = '' not accept ''
in AuthController.php
$user->force_pass_reset = false;
not convert to 0, but is ''
PHP: 7.4.3 — CodeIgniter: 4.1.1
The text was updated successfully, but these errors were encountered: