Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix phpstan error on PermissionModel #578

Closed
wants to merge 1 commit into from
Closed

fix phpstan error on PermissionModel #578

wants to merge 1 commit into from

Conversation

manageruz
Copy link
Collaborator

On PermissionModel's addPermissionToUser() method's return type shoud be boolean, BaseResult|false|Query given.

@manageruz
Copy link
Collaborator Author

manageruz commented Oct 25, 2022 •
edited
Loading

We also need to delete two use statements in PermissionModel:
use CodeIgniter\Database\BaseResult;
use CodeIgniter\Database\Query;

This imports give PHPCSFixer error. Remove them on this PR or open new one?

@MGatner
Copy link
Collaborator

MGatner commented Oct 25, 2022

Superseded by #579

@MGatner MGatner closed this Oct 25, 2022
@manageruz manageruz deleted the fix-pipelineissues-phpstan branch October 28, 2022 05:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@manageruz @MGatner