Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Static Analysis Fixes #579

Merged
merged 2 commits into from
Oct 25, 2022
Merged

Static Analysis Fixes #579

merged 2 commits into from
Oct 25, 2022

Conversation

MGatner
Copy link
Collaborator

@MGatner MGatner commented Oct 25, 2022

  • Updates DevKit template files
  • Applies fixes for updated static analysis conditions

@MGatner
Copy link
Collaborator Author

MGatner commented Oct 25, 2022 •
edited
Loading

Note: a few of these ignores will need to be removed if codeigniter4/CodeIgniter4#6756 merges.

Edit: Lonnie already approved; I will update this PR after merging that shortly.

@MGatner MGatner added bug github_actions Pull requests that update Github_actions code dev labels Oct 25, 2022
manageruz
manageruz approved these changes Oct 25, 2022
View reviewed changes
Copy link
Collaborator

@manageruz manageruz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work!

@MGatner
Copy link
Collaborator Author

MGatner commented Oct 25, 2022

Actually, we aren't using framework:develop anymore so this should be merged and we can update it after the next framework release.

Thanks for the review @manageruz!

@MGatner MGatner merged commit 1c646c5 into develop Oct 25, 2022
@MGatner MGatner deleted the phpstan branch October 25, 2022 15:16
@MGatner MGatner mentioned this pull request Oct 25, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@manageruz manageruz manageruz approved these changes

Assignees
No one assigned
Labels
bug dev github_actions Pull requests that update Github_actions code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MGatner @manageruz