Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Storybook config now supports buildMode #1612

Merged
1 commit merged into from
Oct 26, 2020
Merged

Storybook config now supports buildMode #1612

1 commit merged into from
Oct 26, 2020

Conversation

ghost
Copy link

@ghost ghost commented Oct 25, 2020 •
edited by ghost
Loading

✨ Changes

This pull request refines the Storybook config to support build-modes

  • enables faster image-snapshot generation and better development performance.
  • specify mode via shell export: export storybookBuildMode=develop
    • fast - disables Typescript extraction and all add-ons
    • develop - disables "Docs" add-on
    • publish - enables Typescript extraction and full addon-essentials support

Performance for image-snapshots is much improved:

image

Additionally this PR:

  • Upgrade Storybook to 6.0.27 (from 6.0.26)
  • Fix-up FileTree story to keep screenshot intact
  • Updates some snapshots to reflect running Typescript free (no bad default values)

✅ Requirements

  • Includes test coverage for all changes
  • Build and tests are passing
  • Update documentation
  • Updated CHANGELOG
  • Checked for i18n impacts
  • Checked for a11y impacts
  • Check for image-snapshot changes (run yarn image-snapshots locally)
  • PR is ideally < ~400LOC

📷 Screenshots

@ghost ghost force-pushed the luke/storybook-faster branch from 2d620d3 to 5be1b79 Compare October 26, 2020 04:05
@ghost ghost changed the title Luke/storybook faster Storybook config now supports build-modes Oct 26, 2020
@ghost ghost changed the title Storybook config now supports build-modes Storybook config now supports buildMode Oct 26, 2020
@ghost ghost requested a review from mdodgelooker October 26, 2020 04:05
@ghost ghost marked this pull request as ready for review October 26, 2020 04:05
@ghost ghost mentioned this pull request Oct 26, 2020
Closed
Storybook build mode setup
7c94b10 
Snapshot updates
Storybook 6.0.27
Fix-up `FileTree` story to keep screenshot intact
Add develop mode and use consistently
@ghost ghost force-pushed the luke/storybook-faster branch from 5be1b79 to 7c94b10 Compare October 26, 2020 04:43
mdodgelooker
mdodgelooker approved these changes Oct 26, 2020
View reviewed changes
Copy link
Contributor

@mdodgelooker mdodgelooker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This. Is. Awesome.

@ghost ghost merged commit 145f138 into master Oct 26, 2020
@ghost ghost deleted the luke/storybook-faster branch October 26, 2020 16:32
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@mdodgelooker