Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Kotlin: add Gradle task to build a "fat" jar #1344

Closed
tjbanghart opened this issue Jul 20, 2023 · 0 comments · Fixed by #1345
Closed

Kotlin: add Gradle task to build a "fat" jar #1344

tjbanghart opened this issue Jul 20, 2023 · 0 comments · Fixed by #1345
Assignees
@tjbanghart
Labels
enhancement New feature request kotlin Kotlin SDK issues p3 Priority 3

Comments

@tjbanghart
Copy link
Member

tjbanghart commented Jul 20, 2023 •
edited
Loading

I'd like to include the Kotlin SDK in another JVM project. The current jar task only builds the SDK but doesn't include the ktor, gson, or general Kotlin specific dependencies. A dependent project would need to include these separately.

Adding the Shadow plugin will let us build shaded "fat" jars that include all dependencies so developers could build a single jar to bundle.
@tjbanghart tjbanghart self-assigned this Jul 20, 2023
@github-actions github-actions bot added p3 Priority 3 need triage labels Jul 20, 2023
@tjbanghart tjbanghart mentioned this issue Jul 20, 2023
Merged
3 tasks
@drstrangelooker drstrangelooker added enhancement New feature request kotlin Kotlin SDK issues and removed need triage labels Jul 24, 2023
tjbanghart added a commit that referenced this issue Mar 26, 2024
@tjbanghart
feat: add Shadow plugin to build shaded Kotlin jars (#1345)
dfab079 
Adds the [Shadow](https://github.com/johnrengelman/shadow) plugin. This
will let us build shaded jars that include all dependencies so
developers can use the Kotlin SDK as a standalone jar in other JVM
projects.

Fixes #1344 

## Developer Checklist
[ℹ️](https://github.com/looker-open-source/sdk-codegen/blob/main/CONTRIBUTING.md#developer-checklist)

Thank you for opening a Pull Request! Before submitting your PR, there
are a few things you can do to make sure it goes smoothly:
- [x] Make sure to open an issue as a
[bug/issue](https://github.com/looker-open-source/sdk-codegen/issues/new/choose)
before writing your code! That way we can discuss the change, evaluate
designs, and agree on the general idea
- [x] Ensure the tests and linter pass
- [x] Appropriate docs were updated (if necessary)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tjbanghart tjbanghart

Labels
enhancement New feature request kotlin Kotlin SDK issues p3 Priority 3
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: add Shadow plugin to build shaded Kotlin jars looker-open-source/sdk-codegen
2 participants
@drstrangelooker @tjbanghart