Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add Shadow plugin to build shaded Kotlin jars #1345

Merged
merged 5 commits into from
Mar 26, 2024
Merged

feat: add Shadow plugin to build shaded Kotlin jars #1345

merged 5 commits into from
Mar 26, 2024

Conversation

tjbanghart
Copy link
Member

@tjbanghart tjbanghart commented Jul 20, 2023 •
edited by wnob

Adds the Shadow plugin. This will let us build shaded jars that include all dependencies so developers can use the Kotlin SDK as a standalone jar in other JVM projects.

Fixes #1344

Developer Checklist ℹ️

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Appropriate docs were updated (if necessary)

@tjbanghart tjbanghart requested a review from kalenp July 21, 2023 17:55
kalenp
kalenp previously approved these changes Jul 24, 2023
View reviewed changes
Copy link
Contributor

@kalenp kalenp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm assuming you've testing building the jar with this plugin and verified that it includes the expected dependencies.

@tjbanghart
Copy link
Member Author

Yeah this works as expected!

Although, I think #1343 should get merged first since it includes a similar gradle + kotlin version changes. I snuck a gradle version bump in here.

@tjbanghart tjbanghart mentioned this pull request Sep 21, 2023
Merged
3 tasks
deanlooker added a commit that referenced this pull request Feb 27, 2024
@deanlooker
updating examples - addresses PR #1345
a9c7e96
deanlooker added a commit that referenced this pull request Feb 27, 2024
@deanlooker
updating examples - addresses PR #1345 (#1436)
62b3d56 
- changes import statements to `import models40 as models` for examples
- fixed comment formatting on a few files
@tjbanghart tjbanghart requested a review from a team as a code owner March 12, 2024 22:37
@tjbanghart tjbanghart merged commit dfab079 into main Mar 26, 2024
11 checks passed
@tjbanghart tjbanghart deleted the tjbanghart/fat-jar branch March 26, 2024 17:57
Merged
jeremytchang pushed a commit that referenced this pull request Apr 5, 2024
@looker-open-source-automation-bot
chore: release main (#1449)
ce27df4 
🤖 I have created a release *beep* *boop*
---


<details><summary>@looker/api-explorer: 0.9.59</summary>

### Dependencies

* The following workspace dependencies were updated
  * dependencies
    * @looker/extension-utils bumped from 0.1.35 to 0.1.36
    * @looker/run-it bumped from 0.9.58 to 0.9.59
    * @looker/sdk bumped from 24.2.1 to 24.4.0
  * devDependencies
    * @looker/sdk-codegen-scripts bumped from 21.5.15 to 21.5.16
    * @looker/sdk-node bumped from 24.2.1 to 24.4.0
</details>

<details><summary>@looker/extension-api-explorer: 22.21.16</summary>

### Dependencies

* The following workspace dependencies were updated
  * dependencies
    * @looker/api-explorer bumped from 0.9.58 to 0.9.59
    * @looker/extension-sdk bumped from 24.2.1 to 24.4.0
    * @looker/extension-sdk-react bumped from 24.2.1 to 24.4.0
    * @looker/extension-utils bumped from 0.1.35 to 0.1.36
    * @looker/run-it bumped from 0.9.58 to 0.9.59
    * @looker/sdk bumped from 24.2.1 to 24.4.0
</details>

<details><summary>@looker/extension-playground: 1.0.16</summary>

### Dependencies

* The following workspace dependencies were updated
  * dependencies
    * @looker/extension-sdk bumped from 24.2.1 to 24.4.0
    * @looker/extension-sdk-react bumped from 24.2.1 to 24.4.0
    * @looker/sdk bumped from 24.2.1 to 24.4.0
</details>

<details><summary>@looker/extension-tile-playground: 1.1.3</summary>

### Dependencies

* The following workspace dependencies were updated
  * dependencies
    * @looker/extension-sdk bumped from 24.2.1 to 24.4.0
    * @looker/extension-sdk-react bumped from 24.2.1 to 24.4.0
    * @looker/sdk bumped from 24.2.1 to 24.4.0
</details>

<details><summary>@looker/extension-utils: 0.1.36</summary>

### Dependencies

* The following workspace dependencies were updated
  * dependencies
    * @looker/extension-sdk bumped from 24.2.1 to 24.4.0
    * @looker/extension-sdk-react bumped from 24.2.1 to 24.4.0
    * @looker/sdk bumped from 24.2.1 to 24.4.0
</details>

<details><summary>@looker/hackathon: 22.21.18</summary>

### Dependencies

* The following workspace dependencies were updated
  * dependencies
    * @looker/extension-sdk bumped from 24.2.1 to 24.4.0
    * @looker/extension-sdk-react bumped from 24.2.1 to 24.4.0
    * @looker/extension-utils bumped from 0.1.35 to 0.1.36
    * @looker/sdk bumped from 24.2.1 to 24.4.0
    * @looker/wholly-artifact bumped from 0.1.16 to 0.1.17
</details>

<details><summary>@looker/run-it: 0.9.59</summary>

### Dependencies

* The following workspace dependencies were updated
  * dependencies
    * @looker/extension-utils bumped from 0.1.35 to 0.1.36
    * @looker/sdk bumped from 24.2.1 to 24.4.0
</details>

<details><summary>@looker/sdk-codegen-scripts: 21.5.16</summary>

### Dependencies

* The following workspace dependencies were updated
  * dependencies
    * @looker/sdk bumped from 24.2.1 to 24.4.0
    * @looker/sdk-node bumped from 24.2.1 to 24.4.0
</details>

<details><summary>@looker/wholly-artifact: 0.1.17</summary>

### Dependencies

* The following workspace dependencies were updated
  * dependencies
    * @looker/sdk bumped from 24.2.1 to 24.4.0
  * devDependencies
    * @looker/sdk-node bumped from 24.2.1 to 24.4.0
</details>

<details><summary>@looker/wholly-sheet: 0.5.55</summary>

### Dependencies

* The following workspace dependencies were updated
  * dependencies
    * @looker/sdk bumped from 24.2.1 to 24.4.0
  * devDependencies
    * @looker/sdk-node bumped from 24.2.1 to 24.4.0
</details>

<details><summary>sdk-codegen-all: 24.4.0</summary>

##
[24.4.0](sdk-codegen-all-v24.3.0...sdk-codegen-all-v24.4.0)
(2024-04-05)


### Features

* add Shadow plugin to build shaded Kotlin jars
([#1345](#1345))
([dfab079](dfab079))
* generate SDKs for Looker 24.4
([#1450](#1450))
([2dd742c](2dd742c))
</details>

<details><summary>looker_sdk: 24.4.0</summary>

##
[24.4.0](looker_sdk-v24.2.1...looker_sdk-v24.4.0)
(2024-04-05)


### Features

* generate SDKs for Looker 24.4
([#1450](#1450))
([2dd742c](2dd742c))
</details>

<details><summary>embed-components: 24.4.0</summary>

##
[24.4.0](embed-components-v24.2.1...embed-components-v24.4.0)
(2024-04-05)


### Miscellaneous Chores

* **embed-components:** Synchronize undefined versions


### Dependencies

* The following workspace dependencies were updated
  * dependencies
    * @looker/embed-services bumped from 24.2.1 to 24.4.0
    * @looker/sdk bumped from 24.2.1 to 24.4.0
  * devDependencies
    * @looker/sdk-node bumped from 24.2.1 to 24.4.0
</details>

<details><summary>embed-services: 24.4.0</summary>

##
[24.4.0](embed-services-v24.2.1...embed-services-v24.4.0)
(2024-04-05)


### Miscellaneous Chores

* **embed-services:** Synchronize undefined versions


### Dependencies

* The following workspace dependencies were updated
  * dependencies
    * @looker/sdk bumped from 24.2.1 to 24.4.0
  * devDependencies
    * @looker/sdk-node bumped from 24.2.1 to 24.4.0
</details>

<details><summary>extension-sdk: 24.4.0</summary>

##
[24.4.0](extension-sdk-v24.2.1...extension-sdk-v24.4.0)
(2024-04-05)


### Miscellaneous Chores

* **extension-sdk:** Synchronize undefined versions


### Dependencies

* The following workspace dependencies were updated
  * dependencies
    * @looker/sdk bumped from 24.2.1 to 24.4.0
</details>

<details><summary>extension-sdk-react: 24.4.0</summary>

##
[24.4.0](extension-sdk-react-v24.2.1...extension-sdk-react-v24.4.0)
(2024-04-05)


### Miscellaneous Chores

* **extension-sdk-react:** Synchronize undefined versions


### Dependencies

* The following workspace dependencies were updated
  * dependencies
    * @looker/extension-sdk bumped from 24.2.1 to 24.4.0
    * @looker/sdk bumped from 24.2.1 to 24.4.0
</details>

<details><summary>sdk: 24.4.0</summary>

##
[24.4.0](sdk-v24.2.1...sdk-v24.4.0)
(2024-04-05)


### Features

* generate SDKs for Looker 24.4
([#1450](#1450))
([2dd742c](2dd742c))
</details>

<details><summary>sdk-node: 24.4.0</summary>

##
[24.4.0](sdk-node-v24.2.1...sdk-node-v24.4.0)
(2024-04-05)


### Miscellaneous Chores

* **sdk-node:** Synchronize undefined versions


### Dependencies

* The following workspace dependencies were updated
  * dependencies
    * @looker/sdk bumped from 24.2.1 to 24.4.0
</details>

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jkaster jkaster jkaster approved these changes

@kalenp kalenp kalenp left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Kotlin: add Gradle task to build a "fat" jar
3 participants
@tjbanghart @kalenp @jkaster