-
Notifications
You must be signed in to change notification settings - Fork 188
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(deps): Updated Kotlin from v1.7.0 to v1.9.10, Gradle from v6.7.… #1379
Conversation
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
@daniel-lopes-optimizely Can you fill out the cla agreement at https://cla.developers.google.com/? Thanks. |
When @daniel-lopes-optimizely does the cla agreement we can rerun the cla/google check and we should be good to go. |
@drstrangelooker I've already signed a CLA through my employer and the check was working previously for me. Looking at the failing check my author email isn't there anymore, it was replaced by the github reply email in the Merge commit. |
@drstrangelooker I've fixed the merge commit author on my branch, should work now. |
f21fdd2
to
e9752fc
Compare
@daniel-lopes-optimizely I went to my local branch and did Then I pushed the amended commit. |
@tjbanghart ready for review |
hi @tjbanghart @drstrangelooker can we get this merged? |
I'm reverting another change that hit main, then I'll get this merged. |
@tjbanghart @daniel-lopes-optimizely Can you resolve these conflicts? Most are trivial but |
…1 to v8.3 and upgraded linter
…1 to v8.3 and upgraded linter adding foojay-resolver-convention gradle plugin
…1 to v8.3 and upgraded linter setting gradle jvm toolchain version from 8 to 17
…1 to v8.4 and upgraded linter setting gradle jvm toolchain version from 8 to 17
@drstrangelooker @tjbanghart I've updated my branch with the latest changes from main |
e9752fc
to
71808f6
Compare
@tjbanghart I got the new changes from @daniel-lopes-optimizely. Can you review please? |
…1 to v8.3 and upgraded linter (#1343)
chore(deps): Updated Kotlin from v1.7.0 to v1.9.10, Gradle from v6.7.1 to v8.3 and upgraded linter
chore(deps): upgraded kotlin linter formatted code
chore(deps): Updated Kotlin from v1.7.0 to v1.9.10, Gradle from v6.7.1 to v8.3 and upgraded linter
adding foojay-resolver-convention gradle plugin
setting gradle jvm toolchain version from 8 to 17
from #1343