chore(deps): Updated Kotlin from v1.7.0 to v1.9.10, Gradle from v6.7.1 to v8.3 and upgraded linter #1343
Conversation
daniel-lopes-optimizely
force-pushed
the
kotlin-gradle-upgrade
branch
from
a390471
to
0f9cca6
Compare
| @@ -3207,11 +3011,10 @@ class LookerSDK(authSession: AuthSession) : APIMethods(authSession) { | |||
| */ | |||
| fun create_content_favorite( | |||
| body: WriteContentFavorite | |||
| ) : SDKResponse { | |||
| ): SDKResponse { | |||
There was a problem hiding this comment.
This all LGTM but want to get @drstrangelooker's opinion on formatting the autogen files.
When the SDK is regenerated for the next Looker release we'll probably need to rerun the Kotlin formatter. Is it possible to make that part of the gen task?
There was a problem hiding this comment.
I have no idea about formatting. Sorry
daniel-lopes-optimizely
force-pushed
the
kotlin-gradle-upgrade
branch
from
0f9cca6
to
1f5cbb0
Compare
daniel-lopes-optimizely
force-pushed
the
kotlin-gradle-upgrade
branch
from
2732e40
to
fc723bb
Compare
daniel-lopes-optimizely
force-pushed
the
kotlin-gradle-upgrade
branch
4 times, most recently
from
c887d38
to
e3e1463
Compare
daniel-lopes-optimizely
changed the title
daniel-lopes-optimizely
force-pushed
the
kotlin-gradle-upgrade
branch
from
e3e1463
to
aa09358
Compare
|
Thanks for the PR @daniel-lopes-optimizely! I am seeing the same issue described in #1291 (comment) when trying to build in both Linux and Mac OS. I believe this is due to changes with how gradle locates JVM toolchains. It seems like the In #1345 I was able to change the gradle version with no problem so perhaps some of the other changes are causing this. |
…1 to v8.3 and upgraded linter
…1 to v8.3 and upgraded linter adding foojay-resolver-convention gradle plugin
…1 to v8.3 and upgraded linter setting gradle jvm toolchain version from 8 to 17
daniel-lopes-optimizely
force-pushed
the
kotlin-gradle-upgrade
branch
from
5f81434
to
db5b3c9
Compare
|
Hi @tjbanghart , I wasn't having those issues on my M1 mac. Just in case I added the foojay-resolver-convention plugin to the settings and according to the support response, there's no need to do anything else other than applying the plugin. I also bumped the jvm toolchain version to 17 to keep up with updates, but if you feel that we need 11 to keep backwards compatibility, that's fine too. |
|
Hi @tjbanghart would you know when this PR can be merged? |
drstrangelooker
merged commit f21fdd2
into
looker-open-source:kotlin-gradle-upgrade
|
The checks can't run from a forked repository. I'm merging it to a branch in this repo, and then we will reun the checks locally. |
…1 to v8.3 and upgraded linter (#1343) * chore(deps): Updated Kotlin from v1.7.0 to v1.9.10, Gradle from v6.7.1 to v8.3 and upgraded linter * chore(deps): upgraded kotlin linter formatted code * chore(deps): Updated Kotlin from v1.7.0 to v1.9.10, Gradle from v6.7.1 to v8.3 and upgraded linter adding foojay-resolver-convention gradle plugin * chore(deps): Updated Kotlin from v1.7.0 to v1.9.10, Gradle from v6.7.1 to v8.3 and upgraded linter setting gradle jvm toolchain version from 8 to 17 * chore(deps): upgraded kotlin linter formatted code
#1379) …1 to v8.3 and upgraded linter (#1343) * chore(deps): Updated Kotlin from v1.7.0 to v1.9.10, Gradle from v6.7.1 to v8.3 and upgraded linter * chore(deps): upgraded kotlin linter formatted code * chore(deps): Updated Kotlin from v1.7.0 to v1.9.10, Gradle from v6.7.1 to v8.3 and upgraded linter adding foojay-resolver-convention gradle plugin * chore(deps): Updated Kotlin from v1.7.0 to v1.9.10, Gradle from v6.7.1 to v8.3 and upgraded linter setting gradle jvm toolchain version from 8 to 17 * chore(deps): upgraded kotlin linter formatted code from #1343
This PR upgrades:
Please have a look and let me know how I can further support this PR.
Developer Checklist ℹ️
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes #1277 🦕