-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Lab images #1064
Lab images #1064
Conversation
Thanks! Can you please make new issues for the "TODO" steps if you're not completing them this sprint? Or if you have time, here is a revision for these fields: Banner Image: This image will be shown at the top of your custom URL page, when it is viewed on a laptop/wide browser window. Please keep your file size less than 1 MB. Badge Image: This image will be shown at the top of your custom URL page when it is viewed on a mobile device/narrow browser window, and as a badge/avatar image for your lab. This image should be square. Please keep your file size less than 1 MB. And here are a couple more things, ideal to implement now if time, otherwise please make new issues:
|
Thank you for the giving me to copy. I added it to this PR.
The new image fields are validated. The badge image needs to be square and the banner image is validated to be above a ratio of 2 (w:h). Of course, let me know if you'd like different behavior.
I added commits for these two points. Thank you for the feedback. |
Kudos, SonarCloud Quality Gate passed!
|
Okay, that all sounds good!! |
@okaycj @mekline I know this has been merged but I have a few questions about things I noticed while updating the documentation. I added banner and badge images to the demo lab on staging in order to get some screenshots, and I noticed two things:
WRT to question 2 - if it would be helpful, I can either (a) try to implement the functionality that I was expecting, i.e. banner on wide browser and badge on narrow/mobile (but might take a while to figure out), or (b) edit the form's help text to reflect the current behavior, i.e. the badge image will be shown on the lab page if there is no banner image (faster). Here's a screenshot of the demo lab page on staging, from a desktop browser using the mobile emulator. Note that this page shows the banner rather than badge image, and there's no 'Demo Lab' title. |
Answers to my questions after talking to Melissa and CJ:
|
This PR adds the ability for labs to add a banner and badge image to their customized lab page. The images are validated. The badge image must be square and the banner ratio must be above 2.
Additionally, the lab's description field's help text was updated.
Closes #918