use a background job to mark discussion as read from email open (#10903)

loomio · Jun 15, 2024 · 42d9399 · 42d9399
1 parent cd82c44
commit 42d9399
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 3 deletions.
diff --git a/app/controllers/email_actions_controller.rb b/app/controllers/email_actions_controller.rb
@@ -16,9 +16,13 @@ def unfollow_discussion
    end
 
   def mark_discussion_as_read
-    DiscussionService.mark_as_read(discussion: discussion,
-                                   params: {ranges: event.sequence_id},
-                                   actor: user)
+    GenericWorker.perform_async(
+      'DiscussionService',
+      'mark_as_read_simple_params',
+      discussion.id,
+      event.sequence_id || [],
+      user.id,
+    )
     event.notifications.where(user: user).update_all(viewed: true)
     respond_with_pixel
   rescue ActiveRecord::RecordNotFound

diff --git a/app/services/discussion_service.rb b/app/services/discussion_service.rb
@@ -168,6 +168,12 @@ def self.mark_as_seen(discussion:, actor:)
     EventBus.broadcast('discussion_mark_as_seen', reader, actor)
   end
 
+  def self.mark_as_read_simple_params(discussion_id, ranges, actor_id)
+    discussion = Discussion.find(discussion_id)
+    actor = User.find(actor_id)
+    mark_as_read(discussion: discussion, params: {ranges: ranges}, actor: actor)
+  end
+
   def self.mark_as_read(discussion:, params:, actor:)
     actor.ability.authorize! :mark_as_read, discussion
     RetryOnError.with_limit(2) do