SMT tests & linting #20
Conversation
- adding soliumignore file
…standards - stricter solium linting - basic sol linting changes
- found problematic aspect of SMT impl, values at a particular node do not seem to matter when proving
No objection.
True, if depth is dynamic, the number of bytes should always be
Also true. Although allowing the tree to have dynamic depth is a good upgrade, I believe that we can leave that for later. |
| block = self.get_block(exiting_tx_block_num) | ||
| exiting_tx = block.get_tx_by_uid(uid) | ||
| # make sure this is inclusion | ||
| exiting_tx_inclusion_proof = self.get_proof(exiting_tx_block_num, uid) |
There was a problem hiding this comment.
This is exactly what I had in mind, great
| bytes prevTxBytes, bytes exitingTxBytes, | ||
| bytes prevTxInclusionProof, bytes exitingTxInclusionProof, | ||
| bytes sig, | ||
| uint64 slot, bytes prevTxBytes, |
There was a problem hiding this comment.
The reason I had the arguments formatted like that is because I find them easier to read. Left side is the previousTx information, right side the exiting tx.
All the interesting changes happened in python code, ignore most of the solidity stuff because it's just linting.
challengeBeforein python clientthoughts:
2**(depth-1)RootChaincontract (object).