Feature/verify coin history #38
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gakonst
force-pushed
the
feature/verify-coin-history
branch
from
381b8be
to
6b5488b
Compare
aupiff
approved these changes
Jun 19, 2018
| self.proofs = {} | ||
|
|
||
| # Proof related state | ||
| self.incl_proofs = {} |
There was a problem hiding this comment.
I'm not sure about saving these but if we do, we should make sure to use them somewhere in the get_coin_history function.
| # First get the coin's deposit block | ||
| # todo efficiency -> start_block should be updated to the last block obtained last time |
There was a problem hiding this comment.
Yes, by getting max key from inclusion / exclusion proofs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Did not want to put further commits in order not to mess up #37 so branched to a new one. After we merge #37 let's cherrypick the changes from this.
Adds verify coin history api