Merge pull request #1492 from NextFaze/fix/1486-null-data

Allow passing null to base model ctor
loopbackio · Oct 4, 2017 · 3a6ddf9 · 3a6ddf9
2 parents d213c83 + 99cea38
commit 3a6ddf9
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 1 deletion.
diff --git a/lib/model.js b/lib/model.js
@@ -74,7 +74,7 @@ ModelBaseClass.prototype._initProperties = function(data, options) {
   var self = this;
   var ctor = this.constructor;
 
-  if (typeof data !== 'undefined' && data.constructor &&
+  if (typeof data !== 'undefined' && data !== null && data.constructor &&
       typeof (data.constructor) !== 'function') {
     throw new Error(g.f('Property name "{{constructor}}" is not allowed in %s data', ctor.modelName));
   }

diff --git a/test/datatype.test.js b/test/datatype.test.js
@@ -170,6 +170,17 @@ describe('datatypes', function() {
     });
   });
 
+  it('handles null data', (done) => {
+    db = getSchema();
+    Model = db.define('MyModel', {
+      data: {type: 'string'},
+    });
+    db.automigrate(['Model'], function() {
+      let a = new Model(null);
+      done();
+    });
+  });
+
   describe('model option persistUndefinedAsNull', function() {
     var TestModel, isStrict;
     before(function(done) {