Allow passing null to base model ctor #1492
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zbarbuto
requested review from
b-admike,
dhmlau,
jannyHou,
kjdelisle,
lehni,
loay and
virkt25
as code owners
|
Wasn't exactly sure where to put the test - can be moved anywhere that makes sense. |
|
@slnode test please |
|
Can't seem to view what is causing the failures. Detail links aren't loading for me. |
|
Anyone able to help with why this may be failing? |
|
@slnode test please |
bajtos
approved these changes
Oct 4, 2017
There was a problem hiding this comment.
Hello @zbarbuto, thank you for the pull request. Your proposal to fix the issue here in juggler makes perfect sense to me.
I checked the failed CI builds of our downstream consumers, they seem to be unrelated to your changes.
I think this pull request is good to be merged 👍
|
Landed, thank you! 🎉 |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Redis connector will pass null back if entity is not found causing
data.constructorto throw an error. Rather than updating the connector, I figured it's probably best to check for null as well since undefined is already being checked.Related issues
Checklist
guide