Validations configuration as object #259
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The new Validatable.validations mixin method returns the validations as an object indexed by property name.
Previously validations were appended to an array when configured. The format was cumbersome, and led to issues. This refactors the configuration into an object, as a property of the Model. Note that if no validations have been configured, this property is currently `undefined`.
This was referenced Aug 26, 2014
Closed
Fixes loopbackio#154 - args should only contain the property name at that point, not loop over it.
Closed
raymondfeng
added a commit
that referenced
this pull request
Aug 31, 2014
Validations configuration as object
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously validations were appended to an array when configured. The format was cumbersome, and led to issues. This refactors the configuration into an object, as a property of the Model.
Note that if no validations have been configured, this property is currently
undefined.@raymondfeng any thoughts on having a getter for
Model.validationsthat's always available, regardless of any configuration?