fix: this.definition.idName is not a function

Signed-off-by: Francisco Buceta <frbuceta@gmail.com>
loopbackio · Oct 24, 2020 · 0de5522 · 0de5522
1 parent bbe0397
commit 0de5522
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 1 deletion.
diff --git a/packages/repository/src/__tests__/unit/model/model.unit.ts b/packages/repository/src/__tests__/unit/model/model.unit.ts
@@ -522,6 +522,16 @@ describe('model', () => {
     });
   });
 
+  it('gets id of an object through a static method', () => {
+    const userId = User.getIdOf({
+      id: '53',
+      email: 'loopback@localhost',
+      password: 'l00pback',
+      firstName: 'Loopback User',
+    });
+    expect(userId).to.eql('53');
+  });
+
   describe('rejectNavigationalPropertiesInData', () => {
     class Order extends Entity {
       static definition = new ModelDefinition('Order')

diff --git a/packages/repository/src/model.ts b/packages/repository/src/model.ts
@@ -437,7 +437,8 @@ export abstract class Entity extends Model implements Persistable {
       return entityOrData.getId();
     }
 
-    const idName = this.definition.idName();
+    // const idName = this.definition.idName();
+    const idName = this.getIdProperties()[0];
     return entityOrData[idName];
   }