Skip to content

Commit

Permalink
fix(cli): enforce an empty object on connectors without settings prop…
Browse files Browse the repository at this point in the history
…erty

fix #1697
  • Loading branch information
marioestradarosa committed Sep 12, 2018
1 parent b904e2c commit 111442b
Showing 1 changed file with 5 additions and 4 deletions.
9 changes: 5 additions & 4 deletions packages/cli/generators/datasource/index.js
Expand Up @@ -150,11 +150,12 @@ module.exports = class DataSourceGenerator extends ArtifactGenerator {
promptConnectorConfig() {
debug('prompting for connector config');
// Check to make sure connector is from connectors list (not custom)
const settings = connectors[this.artifactInfo.connector]
? connectors[this.artifactInfo.connector]['settings']
: {};

const settings =
(connectors[this.artifactInfo.connector] &&
connectors[this.artifactInfo.connector]['settings']) ||
{};
const prompts = [];

// Create list of questions to prompt the user
Object.entries(settings).forEach(([key, setting]) => {
// Set defaults and merge with `setting` to override properties
Expand Down

0 comments on commit 111442b

Please sign in to comment.