fix: rework tslint comments disabling "no-unused-variable" rule

loopbackio · Jan 7, 2019 · a18a3d7 · a18a3d7
1 parent 78c9d36
commit a18a3d7
Show file tree

Hide file tree

Showing 26 changed files with 48 additions and 52 deletions.
diff --git a/packages/boot/test/fixtures/application.ts b/packages/boot/test/fixtures/application.ts
@@ -10,7 +10,7 @@ import {ServiceMixin} from '@loopback/service-proxy';
 import {BootMixin} from '../..';
 
 // Force package.json to be copied to `dist` by `tsc`
-//tslint:disable-next-line:no-unused-variable
+//tslint:disable-next-line:no-unused
 import * as pkg from './package.json';
 
 export class BooterApp extends BootMixin(

diff --git a/packages/context/src/binding-key.ts b/packages/context/src/binding-key.ts
@@ -5,7 +5,7 @@
 
 export type BindingAddress<T> = string | BindingKey<T>;
 
-// tslint:disable-next-line:no-unused-variable
+// tslint:disable-next-line:no-unused
 export class BindingKey<ValueType> {
   static readonly PROPERTY_SEPARATOR = '#';
 

diff --git a/packages/context/src/resolution-session.ts b/packages/context/src/resolution-session.ts
@@ -13,7 +13,7 @@ const debugSession = debugModule('loopback:context:resolver:session');
 const getTargetName = DecoratorFactory.getTargetName;
 
 // NOTE(bajtos) The following import is required to satisfy TypeScript compiler
-// tslint:disable-next-line:no-unused-variable
+// tslint:disable-next-line:no-unused
 import {BindingKey} from './binding-key';
 
 /**

diff --git a/packages/context/test/unit/inject.unit.ts b/packages/context/test/unit/inject.unit.ts
@@ -12,7 +12,7 @@ import {
 
 describe('function argument injection', () => {
   it('can decorate class constructor arguments', () => {
-    // tslint:disable-next-line:no-unused-variable
+    // tslint:disable-next-line:no-unused
     class TestClass {
       constructor(@inject('foo') foo: string) {}
     }
@@ -29,7 +29,7 @@ describe('function argument injection', () => {
   });
 
   it('can retrieve information about injected method arguments', () => {
-    // tslint:disable-next-line:no-unused-variable
+    // tslint:disable-next-line:no-unused
     class TestClass {
       test(@inject('foo') foo: string) {}
     }
@@ -97,7 +97,7 @@ describe('function argument injection', () => {
 
 describe('property injection', () => {
   it('can decorate properties', () => {
-    // tslint:disable-next-line:no-unused-variable
+    // tslint:disable-next-line:no-unused
     class TestClass {
       @inject('foo')
       foo: string;
@@ -126,7 +126,7 @@ describe('property injection', () => {
 
   it('cannot decorate static properties', () => {
     expect(() => {
-      // tslint:disable-next-line:no-unused-variable
+      // tslint:disable-next-line:no-unused
       class TestClass {
         @inject('foo')
         static foo: string;
@@ -136,7 +136,7 @@ describe('property injection', () => {
 
   it('cannot decorate a method', () => {
     expect(() => {
-      // tslint:disable-next-line:no-unused-variable
+      // tslint:disable-next-line:no-unused
       class TestClass {
         @inject('bar')
         foo() {}

diff --git a/packages/context/test/unit/resolution-session.unit.ts b/packages/context/test/unit/resolution-session.unit.ts
@@ -8,7 +8,7 @@ import {ResolutionSession, Binding, Injection, inject} from '../..';
 
 describe('ResolutionSession', () => {
   class MyController {
-    // tslint:disable-next-line:no-unused-variable
+    // tslint:disable-next-line:no-unused
     constructor(@inject('b') private b: string) {}
   }
   function givenInjection(): Injection {

diff --git a/packages/metadata/src/types.ts b/packages/metadata/src/types.ts
@@ -17,6 +17,7 @@ export type DecoratorType =
  * @typeparam T Type of the metadata value
  * @typeparam D Type of the decorator
  */
+// tslint:disable-next-line:no-unused
 export class MetadataAccessor<T, D extends DecoratorType = DecoratorType> {
   private constructor(public readonly key: string) {}
 

diff --git a/packages/metadata/test/unit/decorator-factory.unit.ts b/packages/metadata/test/unit/decorator-factory.unit.ts
@@ -113,7 +113,7 @@ describe('ClassDecoratorFactory', () => {
     expect(() => {
       @classDecorator({x: 1})
       @classDecorator({y: 2})
-      // tslint:disable-next-line:no-unused-variable
+      // tslint:disable-next-line:no-unused
       class MyController {}
     }).to.throw(
       /Decorator cannot be applied more than once on class MyController/,
@@ -352,7 +352,7 @@ describe('PropertyDecoratorFactory', () => {
 
   it('throws if applied more than once on the same property', () => {
     expect(() => {
-      // tslint:disable-next-line:no-unused-variable
+      // tslint:disable-next-line:no-unused
       class MyController {
         @propertyDecorator({x: 1})
         @propertyDecorator({y: 2})
@@ -400,7 +400,7 @@ describe('PropertyDecoratorFactory for static properties', () => {
 
   it('throws if applied more than once on the same static property', () => {
     expect(() => {
-      // tslint:disable-next-line:no-unused-variable
+      // tslint:disable-next-line:no-unused
       class MyController {
         @propertyDecorator({x: 1})
         @propertyDecorator({y: 2})
@@ -448,7 +448,7 @@ describe('MethodDecoratorFactory', () => {
 
   it('throws if applied more than once on the same method', () => {
     expect(() => {
-      // tslint:disable-next-line:no-unused-variable
+      // tslint:disable-next-line:no-unused
       class MyController {
         @methodDecorator({x: 1})
         @methodDecorator({y: 2})
@@ -496,7 +496,7 @@ describe('MethodDecoratorFactory for static methods', () => {
 
   it('throws if applied more than once on the same static method', () => {
     expect(() => {
-      // tslint:disable-next-line:no-unused-variable
+      // tslint:disable-next-line:no-unused
       class MyController {
         @methodDecorator({x: 1})
         @methodDecorator({y: 2})
@@ -545,7 +545,7 @@ describe('ParameterDecoratorFactory', () => {
 
   it('throws if applied more than once on the same parameter', () => {
     expect(() => {
-      // tslint:disable-next-line:no-unused-variable
+      // tslint:disable-next-line:no-unused
       class MyController {
         myMethod(
           @parameterDecorator({x: 1})
@@ -634,7 +634,7 @@ describe('ParameterDecoratorFactory for a static method', () => {
 
   it('throws if applied more than once on the same parameter', () => {
     expect(() => {
-      // tslint:disable-next-line:no-unused-variable
+      // tslint:disable-next-line:no-unused
       class MyController {
         static myMethod(
           @parameterDecorator({x: 1})
@@ -695,7 +695,7 @@ describe('MethodParameterDecoratorFactory with invalid decorations', () => {
 
   it('reports error if the # of decorations exceeeds the # of params', () => {
     expect(() => {
-      // tslint:disable-next-line:no-unused-variable
+      // tslint:disable-next-line:no-unused
       class MyController {
         @methodParameterDecorator({x: 1}) // Causing error
         @methodParameterDecorator({x: 2}) // For a

diff --git a/packages/openapi-v3-types/test/unit/openapi-v3-spec-types.unit.ts b/packages/openapi-v3-types/test/unit/openapi-v3-spec-types.unit.ts
@@ -57,7 +57,7 @@ describe('openapi-v3-types unit tests', () => {
      * original OAS 3 definition. (Though some interfaces allow for extensibility).
      */
 
-    // tslint:disable-next-line:no-unused-variable
+    // tslint:disable-next-line:no-unused
     class TestObject implements ExampleObject {
       summary: 'test object';
       description: 'test object';
@@ -66,20 +66,20 @@ describe('openapi-v3-types unit tests', () => {
       randomProperty: 'extension value';
     }
 
-    // tslint:disable-next-line:no-unused-variable
+    // tslint:disable-next-line:no-unused
     class ReferenceTestObject implements ReferenceObject {
       $ref: '#def/reference-object';
     }
 
-    // tslint:disable-next-line:no-unused-variable
+    // tslint:disable-next-line:no-unused
     class DiscriminatorTestObject implements DiscriminatorObject {
       propertyName: 'test';
       mapping: {
         hello: 'world';
       };
     }
 
-    // tslint:disable-next-line:no-unused-variable
+    // tslint:disable-next-line:no-unused
     class XMLTestObject implements XmlObject {
       name: 'test';
       namespace: 'test';
@@ -88,13 +88,13 @@ describe('openapi-v3-types unit tests', () => {
       wrapped: false;
     }
 
-    // tslint:disable-next-line:no-unused-variable
+    // tslint:disable-next-line:no-unused
     class TestExternalDocumentationObject
       implements ExternalDocumentationObject {
       url: 'https://test.com/test.html';
     }
 
-    // tslint:disable-next-line:no-unused-variable
+    // tslint:disable-next-line:no-unused
     class TestISpecificationExtension implements ISpecificationExtension {
       test: 'test';
     }

diff --git a/packages/openapi-v3/test/unit/decorators/param/param.decorator.unit.ts b/packages/openapi-v3/test/unit/decorators/param/param.decorator.unit.ts
@@ -164,7 +164,7 @@ describe('Routing metadata for parameters', () => {
     it('reports error if an array parameter type is not Array', () => {
       expect.throws(
         () => {
-          // tslint:disable-next-line:no-unused-variable
+          // tslint:disable-next-line:no-unused
           class MyController {
             @get('/greet')
             greet(

diff --git a/packages/repository-json-schema/test/unit/json-schema.unit.ts b/packages/repository-json-schema/test/unit/json-schema.unit.ts
@@ -15,7 +15,7 @@ describe('JSON Schema type', () => {
      * Inspired by https://github.com/DefinitelyTyped/DefinitelyTyped/blob/master/types/json-schema/json-schema-tests.ts
      */
 
-    // tslint:disable-next-line:no-unused-variable
+    // tslint:disable-next-line:no-unused
     const testSchema: JsonSchema = {
       $id: 'test',
       $ref: 'test/sub',

diff --git a/packages/repository/examples/controllers/customer-with-constructor-di.controller.ts b/packages/repository/examples/controllers/customer-with-constructor-di.controller.ts
@@ -3,7 +3,7 @@
 // This file is licensed under the MIT License.
 // License text available at https://opensource.org/licenses/MIT
 
-// tslint:disable:no-unused-variable
+// tslint:disable:no-unused
 
 import {EntityCrudRepository, repository} from '../..';
 import {Customer} from '../models/customer.model';
@@ -15,7 +15,7 @@ import {Customer} from '../models/customer.model';
 export class CustomerController {
   constructor(
     // Use constructor dependency injection
-    // tslint:disable-next-line:no-unused-variable
+    // tslint:disable-next-line:no-unused
     @repository('Customer', 'mongodbDataSource')
     private _repository: EntityCrudRepository<Customer, string>,
   ) {}

diff --git a/packages/repository/examples/controllers/customer-with-property-di.controller.ts b/packages/repository/examples/controllers/customer-with-property-di.controller.ts
@@ -3,7 +3,7 @@
 // This file is licensed under the MIT License.
 // License text available at https://opensource.org/licenses/MIT
 
-// tslint:disable:no-unused-variable
+// tslint:disable:no-unused
 
 import {EntityCrudRepository, repository} from '../..';
 import {Customer} from '../models/customer.model';

diff --git a/packages/repository/examples/models/order.model.ts b/packages/repository/examples/models/order.model.ts
@@ -6,7 +6,7 @@
 import {belongsTo, Entity, model, property} from '../..';
 import {Customer} from './customer.model';
 
-// tslint:disable:no-unused-variable
+// tslint:disable:no-unused
 
 @model()
 class Order extends Entity {

diff --git a/packages/repository/src/repositories/repository.ts b/packages/repository/src/repositories/repository.ts
@@ -18,7 +18,7 @@ import {CrudConnector} from '../connectors';
 import {Filter, Where} from '../query';
 import {EntityNotFoundError} from '../errors';
 
-// tslint:disable:no-unused-variable
+// tslint:disable:no-unused
 
 export interface Repository<T extends Model> {}
 
@@ -333,7 +333,7 @@ export class CrudRepositoryImpl<T extends Entity, ID>
       );
     } else {
       // FIXME: populate inst with all properties
-      // tslint:disable-next-line:no-unused-variable
+      // tslint:disable-next-line:no-unused
       const inst = data;
       const where = this.entityClass.buildWhereForId(id);
       const result = await this.updateAll(data, where, options);

diff --git a/packages/repository/test/acceptance/has-one.relation.acceptance.ts b/packages/repository/test/acceptance/has-one.relation.acceptance.ts
@@ -5,7 +5,6 @@
 
 import {Application} from '@loopback/core';
 import {expect, toJSON} from '@loopback/testlab';
-import * as _ from 'lodash';
 import {
   ApplicationWithRepositories,
   juggler,

diff --git a/packages/repository/test/unit/decorator/model-and-relation.decorator.unit.ts b/packages/repository/test/unit/decorator/model-and-relation.decorator.unit.ts
@@ -351,7 +351,7 @@ describe('model decorator', () => {
       it('throws when @property.array is used on a non-array property', () => {
         expect.throws(
           () => {
-            // tslint:disable-next-line:no-unused-variable
+            // tslint:disable-next-line:no-unused
             class Oops {
               @property.array(Product)
               product: Product;

diff --git a/packages/repository/test/unit/decorator/relation.decorator.unit.ts b/packages/repository/test/unit/decorator/relation.decorator.unit.ts
@@ -115,7 +115,7 @@ describe('relation decorator', () => {
             province: string;
           }
 
-          // tslint:disable-next-line:no-unused-variable
+          // tslint:disable-next-line:no-unused
           class AddressBook extends Entity {
             id: number;
             @property.array(Entity)

diff --git a/packages/repository/test/unit/decorator/repository.decorator.unit.ts b/packages/repository/test/unit/decorator/repository.decorator.unit.ts
@@ -80,7 +80,7 @@ describe('repository decorator', () => {
   it('throws not implemented for class-level @repository', () => {
     expect(() => {
       @repository('noteRepo')
-      // tslint:disable-next-line:no-unused-variable
+      // tslint:disable-next-line:no-unused
       class Controller1 {}
     }).to.throw(/not implemented/);
   });

diff --git a/packages/repository/test/unit/model/model.unit.ts b/packages/repository/test/unit/model/model.unit.ts
@@ -96,7 +96,7 @@ describe('model', () => {
     }
   }
 
-  // tslint:disable-next-line:no-unused-variable
+  // tslint:disable-next-line:no-unused
   class User extends Entity {
     static definition = userDef;
     id: string;

diff --git a/packages/repository/test/unit/repositories/relation.repository.unit.ts b/packages/repository/test/unit/repositories/relation.repository.unit.ts
@@ -17,7 +17,6 @@ import {
   DefaultCrudRepository,
   DefaultHasManyRepository,
   Entity,
-  EntityCrudRepository,
   Filter,
   HasManyRepository,
   juggler,
@@ -36,12 +35,9 @@ describe('relation repository', () => {
      * interface. The TS Compiler will complain if the interface changes.
      */
 
-    // tslint:disable-next-line:no-unused-variable
-    class testHasManyEntityCrudRepository<
-      T extends Entity,
-      ID,
-      TargetRepository extends EntityCrudRepository<T, ID>
-    > implements HasManyRepository<T> {
+    // tslint:disable-next-line:no-unused
+    class testHasManyEntityCrudRepository<T extends Entity>
+      implements HasManyRepository<T> {
       create(
         targetModelData: DataObject<T>,
         options?: AnyObject | undefined,

diff --git a/packages/rest/test/acceptance/bootstrapping/rest.acceptance.ts b/packages/rest/test/acceptance/bootstrapping/rest.acceptance.ts
@@ -76,7 +76,7 @@ async function startServerCheck(app: Application) {
 }
 
 function sequenceHandler(
-  {request, response}: RequestContext,
+  {response}: RequestContext,
   sequence: DefaultSequence,
 ) {
   sequence.send(response, 'hello world');

diff --git a/packages/rest/test/acceptance/routing/routing.acceptance.ts b/packages/rest/test/acceptance/routing/routing.acceptance.ts
@@ -692,7 +692,7 @@ describe('Routing', () => {
 
     it('provides httpHandler compatible with HTTP server API', async () => {
       const app = new RestApplication();
-      app.handler(({request, response}, sequence) => response.end('hello'));
+      app.handler(({response}, sequence) => response.end('hello'));
 
       await createClientForHandler(app.requestHandler)
         .get('/')

diff --git a/packages/rest/test/acceptance/sequence/sequence.acceptance.ts b/packages/rest/test/acceptance/sequence/sequence.acceptance.ts
@@ -44,7 +44,7 @@ describe('Sequence', () => {
   });
 
   it('allows users to define a custom sequence as a function', () => {
-    server.handler(({request, response}, sequence) => {
+    server.handler(({response}, sequence) => {
       sequence.send(response, 'hello world');
     });
     return whenIRequest()
@@ -98,7 +98,7 @@ describe('Sequence', () => {
     class MySequence implements SequenceHandler {
       constructor(@inject(SequenceActions.SEND) protected send: Send) {}
 
-      async handle({request, response}: RequestContext) {
+      async handle({response}: RequestContext) {
         this.send(response, 'MySequence was invoked.');
       }
     }

diff --git a/packages/rest/test/unit/re-export.unit.ts b/packages/rest/test/unit/re-export.unit.ts
@@ -6,7 +6,7 @@ import {get} from '../..';
 
 describe('re-export controller decorators', () => {
   it('exports functions from @loopback/openapi-v3', async () => {
-    /* tslint:disable-next-line:no-unused-variable */
+    /* tslint:disable-next-line:no-unused */
     class Test {
       // Make sure the decorators are exported
       @get('/test')