refactor: clean up after connectorFeatures rename

Clean up remaining places referencing "connectorFeatures" to use "features" instead. Signed-off-by: Miroslav Bajtoš <mbajtoss@gmail.com>
loopbackio · Jul 22, 2019 · c6c74d0 · c6c74d0
1 parent 055eeeb
commit c6c74d0
Show file tree

Hide file tree

Showing 6 changed files with 13 additions and 13 deletions.
diff --git a/packages/repository-tests/README.md b/packages/repository-tests/README.md
@@ -67,7 +67,7 @@ tests:
 export function createRetrieveSuite(
   dataSourceOptions: DataSourceOptions,
   repositoryClass: CrudRepositoryCtor,
-  connectorFeatures: CrudConnectorFeatures,
+  features: CrudFeatures,
 ) {
   // test code
 }

diff --git a/packages/repository-tests/src/crud-test-suite.ts b/packages/repository-tests/src/crud-test-suite.ts
@@ -20,26 +20,26 @@ const debug = debugFactory('loopback:repository-tests');
 type SuiteFn = (
   dataSourceOptions: DataSourceOptions,
   repositoryClass: CrudRepositoryCtor,
-  connectorFeatures: CrudFeatures,
+  features: CrudFeatures,
 ) => void;
 
 export function crudRepositoryTestSuite(
   dataSourceOptions: DataSourceOptions,
   repositoryClass: CrudRepositoryCtor,
-  connectorFeatures: Partial<CrudFeatures>,
+  partialFeatures: Partial<CrudFeatures>,
 ) {
   const features: CrudFeatures = {
     idType: 'string',
     freeFormProperties: true,
-    ...connectorFeatures,
+    ...partialFeatures,
   };
 
   describe('CRUD Repository operations', () => {
     before(
       withCrudCtx(function setupContext(ctx: CrudTestContext) {
         ctx.dataSourceOptions = dataSourceOptions;
         ctx.repositoryClass = repositoryClass;
-        ctx.connectorFeatures = features;
+        ctx.features = features;
       }),
     );
     before(
@@ -70,7 +70,7 @@ export function crudRepositoryTestSuite(
           suite.name,
           dataSourceOptions,
           'class ' + repositoryClass.name,
-          connectorFeatures,
+          partialFeatures,
         );
         suite(dataSourceOptions, repositoryClass, features);
       }

diff --git a/packages/repository-tests/src/crud/create-retrieve.suite.ts b/packages/repository-tests/src/crud/create-retrieve.suite.ts
@@ -19,12 +19,12 @@ import {
 export function createRetrieveSuite(
   dataSourceOptions: DataSourceOptions,
   repositoryClass: CrudRepositoryCtor,
-  connectorFeatures: CrudFeatures,
+  features: CrudFeatures,
 ) {
   @model()
   class Product extends Entity {
     @property({
-      type: connectorFeatures.idType,
+      type: features.idType,
       id: true,
       generated: true,
       description: 'The unique identifier for a product',

diff --git a/packages/repository-tests/src/crud/freeform-properties.suite.ts b/packages/repository-tests/src/crud/freeform-properties.suite.ts
@@ -18,17 +18,17 @@ import {
 export function freeformPropertiesSuite(
   dataSourceOptions: DataSourceOptions,
   repositoryClass: CrudRepositoryCtor,
-  connectorFeatures: CrudFeatures,
+  features: CrudFeatures,
 ) {
   skipIf<[(this: Suite) => void], void>(
-    !connectorFeatures.freeFormProperties,
+    !features.freeFormProperties,
     describe,
     'free-form properties (strict: false)',
     () => {
       @model({settings: {strict: false}})
       class Freeform extends Entity {
         @property({
-          type: connectorFeatures.idType,
+          type: features.idType,
           id: true,
           description: 'The unique identifier for a product',
         })

diff --git a/packages/repository-tests/src/types.repository-tests.ts b/packages/repository-tests/src/types.repository-tests.ts
@@ -60,6 +60,6 @@ export type CrudRepositoryCtor = new <
 export interface CrudTestContext {
   dataSourceOptions: DataSourceOptions;
   repositoryClass: CrudRepositoryCtor;
-  connectorFeatures: CrudFeatures;
+  features: CrudFeatures;
   dataSource: juggler.DataSource;
 }
diff --git a/packages/testlab/src/skip.ts b/packages/testlab/src/skip.ts
@@ -17,7 +17,7 @@ export type TestDefinition<ARGS extends unknown[], RETVAL> = (
  * @example
  * ```ts
  * skipIf(
- *   !connectorFeatures.freeFormProperties,
+ *   !features.freeFormProperties,
  *   describe,
  *  'free-form properties (strict: false)',
  *   () => {