fix(context): allow optional for a binding without value getter

loopbackio · May 26, 2019 · e211a71 · e211a71
1 parent 1143b5d
commit e211a71
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 0 deletions.
diff --git a/packages/context/src/__tests__/unit/binding.unit.ts b/packages/context/src/__tests__/unit/binding.unit.ts
@@ -229,6 +229,13 @@ describe('Binding', () => {
       );
     });
 
+    it('allows optional if binding does not have a value getter', () => {
+      // This can happen for `@inject.binding`
+      ctx.bind('child.options');
+      const childOptions = ctx.getSync('child.options', {optional: true});
+      expect(childOptions).to.be.undefined();
+    });
+
     it('allows optional if alias binding cannot be resolved', () => {
       ctx.bind('child.options').toAlias('parent.options#child');
       const childOptions = ctx.getSync('child.options', {optional: true});

diff --git a/packages/context/src/binding.ts b/packages/context/src/binding.ts
@@ -299,6 +299,8 @@ export class Binding<T = BoundValue> {
       );
       return this._cacheValue(ctx, result);
     }
+    // `@inject.binding` adds a binding without _getValue
+    if (options.optional) return undefined;
     return Promise.reject(
       new Error(`No value was configured for binding ${this.key}.`),
     );