Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow multiple models with same name #24

Closed
3 tasks
deepakrkris opened this issue Feb 1, 2017 · 6 comments
Closed
3 tasks

Allow multiple models with same name #24

deepakrkris opened this issue Feb 1, 2017 · 6 comments

Comments

@deepakrkris
Copy link
Contributor

  • - Models should be classified with namespaces, preferrably in the java style package names.
  • - Packaging (folder) paths like /common/models or loopback/models can be name spaces
  • - this will allow having models with same names to be configured
@ritch
Copy link
Contributor

ritch commented Feb 22, 2017

Renaming to focus on the problem at hand

@ritch ritch changed the title Support namespace for Models Allow multiple models with same name Feb 22, 2017
@superkhau
Copy link
Contributor

superkhau commented Jun 26, 2017

@raymondfeng Does your proposal at #392 already consider this (is issue this safe to close)?

@bajtos
Copy link
Member

bajtos commented Dec 15, 2017

Does your proposal at #392 already consider this (is issue this safe to close)?

Not really. The current DefaultCrudRepository is building a backing PersistedModel that's sharing the same model name with the TS-based Entity class.

@dhmlau
Copy link
Member

dhmlau commented Mar 27, 2018

Discussion with @bajtos @raymondfeng:

  • allow same model definition to be used to connect to different database
  • model has to be uniquely accessible. Introduce qualified name (namespace).
  • it could be current limitation of juggler
  • a spike might be needed.

@stale
Copy link

stale bot commented Oct 28, 2019

This issue has been marked stale because it has not seen activity within six months. If you believe this to be in error, please contact one of the code owners, listed in the CODEOWNERS file at the top-level of this repository. This issue will be closed within 30 days of being stale.

@stale stale bot added the stale label Oct 28, 2019
@stale
Copy link

stale bot commented Nov 27, 2019

This issue has been closed due to continued inactivity. Thank you for your understanding. If you believe this to be in error, please contact one of the code owners, listed in the CODEOWNERS file at the top-level of this repository.

@stale stale bot closed this as completed Nov 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants