Implement @repository(model, dataSource) injection #392
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raymondfeng
force-pushed
the
implement-repo-factory
branch
from
b0102f1
to
e0623ab
Compare
bajtos
approved these changes
Jun 26, 2017
| @@ -24,15 +25,15 @@ export class RepositoryMetadata { | |||
| /** | |||
| * Class of the model | |||
| */ | |||
| modelClass?: Class<Model>; | |||
| modelClass?: typeof juggler.PersistedModel | typeof Model; | |||
There was a problem hiding this comment.
Nice. Are there any other places where Class<T> can be replaced with typeof T? Can we perhaps get rid of Class<> entirely?
| } | ||
| return new DefaultCrudRepository( | ||
| modelClass as typeof juggler.PersistedModel, | ||
| dataSource! as juggler.DataSource); |
There was a problem hiding this comment.
What if dataSource is null? Shouldn't we report a helpful error in such case?
This was referenced Jun 26, 2017
raymondfeng
force-pushed
the
implement-repo-factory
branch
4 times, most recently
from
9fda98f
to
54d04de
Compare
raymondfeng
force-pushed
the
implement-repo-factory
branch
from
54d04de
to
f5f88e8
Compare
raymondfeng
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc @bajtos @raymondfeng @ritch @superkhau